From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9895 invoked by alias); 19 Oct 2012 17:00:35 -0000 Received: (qmail 9795 invoked by uid 22791); 19 Oct 2012 17:00:30 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Oct 2012 17:00:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DD92A2E07E; Fri, 19 Oct 2012 13:00:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EIZ1uoDoIHVJ; Fri, 19 Oct 2012 13:00:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A9B982E07C; Fri, 19 Oct 2012 13:00:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id BD22DC800D; Fri, 19 Oct 2012 10:00:14 -0700 (PDT) Date: Fri, 19 Oct 2012 17:00:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: RFC: fix bug in compare_breakpoints Message-ID: <20121019170014.GX3050@adacore.com> References: <87sj9c28o1.fsf@fleche.redhat.com> <507FC362.5070906@redhat.com> <87lif3y27l.fsf@fleche.redhat.com> <87lif2wi6c.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lif2wi6c.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00355.txt.bz2 > I do think it is a mild improvement. It is a lot easier to mistype a > ";" than a correctly formatted brace pair. Thanks, Tom. I also think it's a mild improvement. It does make we wonder why we need the if/else at all in some of the cases, but that's for another day/patch... -- Joel