From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29519 invoked by alias); 18 Oct 2012 13:45:22 -0000 Received: (qmail 29509 invoked by uid 22791); 18 Oct 2012 13:45:21 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Oct 2012 13:45:10 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IDj5W5007783 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 18 Oct 2012 09:45:07 -0400 Received: from host2.jankratochvil.net (ovpn-116-77.ams2.redhat.com [10.36.116.77]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9IDj0r4026324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 18 Oct 2012 09:45:04 -0400 Date: Thu, 18 Oct 2012 13:45:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: Pedro Alves , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Display full file path in MI style disassembly listing Message-ID: <20121018134500.GB30950@host2.jankratochvil.net> References: <506DB4B8.5030001@broadcom.com> <20121005124353.GA22997@host2.jankratochvil.net> <507EF554.4080404@redhat.com> <20121018064825.GA15668@host2.jankratochvil.net> <507FD088.4030101@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <507FD088.4030101@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00323.txt.bz2 On Thu, 18 Oct 2012 11:48:56 +0200, Andrew Burgess wrote: > I took a look at the original patch. I it changes one place (in > backtrace) where we display symtab->filename. There are several places > where we display symtab->filename, including the one I changed. > > Either, (a) we plan to merge the original patch almost as is, in which > case it only changes the backtrace code, leaving my patch free to be > applied, or (b) we plan to extend the original patch to cover more/all > of the places we display symtab->filename, in which case, we'd have to > consider each of those places in turn and make a suitable change. (b) but this seems to be irrelevant to this patch now. > Jan, if I post a patch that adds a fullpath would you be happy with that > as a solution? Pedro IIUC has shown that if anywhere in MI is missing the "fullname" field you can add it, so far there is no need to change the content of "file" field for the MI purposes. I support this Pedro's proposal. Thanks, Jan