From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17253 invoked by alias); 15 Oct 2012 19:12:53 -0000 Received: (qmail 17245 invoked by uid 22791); 15 Oct 2012 19:12:53 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Oct 2012 19:12:46 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9FJCjfH020022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 15 Oct 2012 15:12:45 -0400 Received: from host2.jankratochvil.net (ovpn-116-24.ams2.redhat.com [10.36.116.24]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9FJCeTk014183 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 15 Oct 2012 15:12:42 -0400 Date: Mon, 15 Oct 2012 19:12:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches@sourceware.org Subject: [commit] Regression for gdb.base/stap-probe.exp (and some others) [Re: [patch] Have gdb_breakpoint call pass] Message-ID: <20121015191239.GA27906@host2.jankratochvil.net> References: <20121012070149.GA5873@host2.jankratochvil.net> <20604.19144.405313.95372@ruffy2.mtv.corp.google.com> <20121015183521.GA26690@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00236.txt.bz2 On Mon, 15 Oct 2012 20:49:59 +0200, Doug Evans wrote: > I gather the issue is that the code is now treating { allow-pending } > like " allow-pending ", and the test for "allow-pending" (no spaces) > is now failing. Surprisingly not, I do not find it too clear: gdb_breakpoint "$function" { allow-pending } -> args=<{ allow-pending }> gdb_breakpoint "$function" {allow-pending} -> args= > Given that gdb_breakpoint is a varargs function, and > parameters like allow-pending are part of the varargs parameters, it > seems wrong to pass allow-pending as a list itself (which the braces > imply), so perhaps we should remove the braces altogether. > i.e., s/{ allow-pending }/allow-pending/ Checked in that way. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2012-10/msg00056.html --- src/gdb/testsuite/ChangeLog 2012/10/15 17:35:54 1.3414 +++ src/gdb/testsuite/ChangeLog 2012/10/15 19:11:56 1.3415 @@ -1,3 +1,11 @@ +2012-10-15 Jan Kratochvil + Doug Evans + + Fix recent gdb_breakpoint regression. + * gdb.java/jmisc.exp: gdb_breakpoint for $function - remove curly + braces from the parameter. + * gdb.java/jprint.exp: Likewise. + 2012-10-15 Doug Evans * lib/gdb.exp (runto): Fix call to gdb_breakpoint. --- src/gdb/testsuite/gdb.java/jmisc.exp 2012/06/22 16:44:15 1.25 +++ src/gdb/testsuite/gdb.java/jmisc.exp 2012/10/15 19:11:56 1.26 @@ -43,8 +43,8 @@ # signature. runto_main set function "${testfile}.main(java.lang.String\[\])" - gdb_breakpoint "$function" { allow-pending } - gdb_breakpoint "${function}void" { allow-pending } + gdb_breakpoint "$function" allow-pending + gdb_breakpoint "${function}void" allow-pending gdb_continue_to_breakpoint $function gdb_test_multiple "ptype jmisc" "ptype jmisc" { --- src/gdb/testsuite/gdb.java/jprint.exp 2012/06/22 16:44:15 1.23 +++ src/gdb/testsuite/gdb.java/jprint.exp 2012/10/15 19:11:56 1.24 @@ -43,8 +43,8 @@ # signature. runto_main set function "${testfile}.main(java.lang.String\[\])" - gdb_breakpoint "$function" { allow-pending } - gdb_breakpoint "${function}void" { allow-pending } + gdb_breakpoint "$function" allow-pending + gdb_breakpoint "${function}void" allow-pending gdb_continue_to_breakpoint $function gdb_test "p jvclass.addprint(4,5,6)" " = 15" "unambiguous static call"