From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2295 invoked by alias); 15 Oct 2012 18:35:38 -0000 Received: (qmail 1783 invoked by uid 22791); 15 Oct 2012 18:35:35 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Oct 2012 18:35:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9FIZQme018648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 15 Oct 2012 14:35:26 -0400 Received: from host2.jankratochvil.net (ovpn-116-24.ams2.redhat.com [10.36.116.24]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9FIZMAn004843 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 15 Oct 2012 14:35:25 -0400 Date: Mon, 15 Oct 2012 18:35:00 -0000 From: Jan Kratochvil To: dje@google.com Cc: gdb-patches@sourceware.org Subject: Re: Regression for gdb.base/stap-probe.exp (and some others) [Re: [patch] Have gdb_breakpoint call pass] Message-ID: <20121015183521.GA26690@host2.jankratochvil.net> References: <20121012070149.GA5873@host2.jankratochvil.net> <20604.19144.405313.95372@ruffy2.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20604.19144.405313.95372@ruffy2.mtv.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00228.txt.bz2 Hi Doug, On Mon, 15 Oct 2012 19:41:28 +0200, dje@google.com wrote: > This patch fixes stap-probe.exp on the Fedora box I tested on. Yes, it does. > I didn't test jmisc.exp but it is likely the same issue. No, it is not. I guess you agree, I will check it in. With '{ allow-pending }' the function gets passed "{ allow-pending }" while with '{allow-pending}' it gets passed "allow-pending". tcl-8.5.12-3.fc18.x86_64 Thanks, Jan gdb/testsuite/ 2012-10-15 Jan Kratochvil Fix recent gdb_breakpoint regression. * gdb.java/jmisc.exp: gdb_breakpoint for $function - remove spaces from curly bracketed parameter. * gdb.java/jprint.exp: Likewise. diff --git a/gdb/testsuite/gdb.java/jmisc.exp b/gdb/testsuite/gdb.java/jmisc.exp index 7215861..64ae559 100644 --- a/gdb/testsuite/gdb.java/jmisc.exp +++ b/gdb/testsuite/gdb.java/jmisc.exp @@ -43,8 +43,8 @@ if [set_lang_java] then { # signature. runto_main set function "${testfile}.main(java.lang.String\[\])" - gdb_breakpoint "$function" { allow-pending } - gdb_breakpoint "${function}void" { allow-pending } + gdb_breakpoint "$function" {allow-pending} + gdb_breakpoint "${function}void" {allow-pending} gdb_continue_to_breakpoint $function gdb_test_multiple "ptype jmisc" "ptype jmisc" { diff --git a/gdb/testsuite/gdb.java/jprint.exp b/gdb/testsuite/gdb.java/jprint.exp index b2d5d31..ac5c55c 100644 --- a/gdb/testsuite/gdb.java/jprint.exp +++ b/gdb/testsuite/gdb.java/jprint.exp @@ -43,8 +43,8 @@ if [set_lang_java] then { # signature. runto_main set function "${testfile}.main(java.lang.String\[\])" - gdb_breakpoint "$function" { allow-pending } - gdb_breakpoint "${function}void" { allow-pending } + gdb_breakpoint "$function" {allow-pending} + gdb_breakpoint "${function}void" {allow-pending} gdb_continue_to_breakpoint $function gdb_test "p jvclass.addprint(4,5,6)" " = 15" "unambiguous static call"