From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2721 invoked by alias); 4 Oct 2012 07:13:30 -0000 Received: (qmail 2703 invoked by uid 22791); 4 Oct 2012 07:13:29 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Oct 2012 07:13:19 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q947DIPu026682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Oct 2012 03:13:18 -0400 Received: from host2.jankratochvil.net (ovpn-116-83.ams2.redhat.com [10.36.116.83]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q947DFKx002671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 4 Oct 2012 03:13:17 -0400 Date: Thu, 04 Oct 2012 07:13:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20121004071314.GA4292@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> <20121003184155.03dceed4@spoyarek> <20121003195627.GA17283@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121003195627.GA17283@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00056.txt.bz2 On Wed, 03 Oct 2012 21:56:27 +0200, Jan Kratochvil wrote: > > grep -q "$loc" splint-bitpos3.locdiff.processed > > This 'grep' has too relaxed search string, for example warnings in "main.c" > (there are some 'conversion' warnings) will match _29_ other files creating > false FOUND lines and therefore fogetting about possibly valid type safety > conversion problems. > > There should be sure some fgrep -q "($loc:" or so. $loc includes the line number which also can have false positives on partial match without anchor so probably something like: fgrep -q "($loc)" Thanks, Jan