From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20131 invoked by alias); 4 Oct 2012 00:09:07 -0000 Received: (qmail 20085 invoked by uid 22791); 4 Oct 2012 00:08:56 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Oct 2012 00:08:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CBE0B1C79BD; Wed, 3 Oct 2012 20:08:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id N0ef+VeX+Xla; Wed, 3 Oct 2012 20:08:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 838431C7808; Wed, 3 Oct 2012 20:08:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 230FBC687C; Thu, 4 Oct 2012 02:08:40 +0200 (CEST) Date: Thu, 04 Oct 2012 00:09:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Khoo Yit Phang , Jan Kratochvil , GDB Patches Subject: Re: [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory Message-ID: <20121004000840.GI3028@adacore.com> References: <20120924145910.GE4146@adacore.com> <2878953E-B698-43F3-989A-A551D96BAB62@cs.umd.edu> <20120924152641.GF4146@adacore.com> <9F52A338-A158-44DC-90C1-F46503859613@cs.umd.edu> <285502C6-1395-4049-9D55-031EDA3AD06D@cs.umd.edu> <20120924170348.GI4146@adacore.com> <20120927091737.GB2980@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00050.txt.bz2 > > Does anyone have any objection to this approach in principle? > > I'm not entirely comfortable with this yet, but I might be persuaded. I have to admit that I have been having second thoughts as well, trying to figure out all the implications of this change. > Alternative: Is there a robust enough test to determine gdb is being > run from its build directory? I don't see a robust way to determine that we are bing run from the build directory. I kind of see this approach as riskier than the first one. I've been mulling over the following two options: 1. Go with the idea of installing the data-directory inside the build directory". But this assumes that the data-directory is relocatable, and that it is a subdirectory of the prefix. If that's not the case, then I think "make all" could end up installing the data-directory at the configured location, outside the build directory. It seems like an innocent thing, but in the end, I think it's bad - almost sneaky. I'd probably be the first one to curse if that happened to me. 2. Accept the new situation, and configure with a --prefix somewhere in the build directory. I can do an install the first time, and then as needed based on what changes have been made since the last install... It's a pain in the neck, but I think I have slowly been coming to the conclusion that it is probably best for me, and the others who were relying on this undocumented feature, to learn to live with the new requirement. At least we tried... -- Joel