From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15929 invoked by alias); 3 Oct 2012 19:56:40 -0000 Received: (qmail 15919 invoked by uid 22791); 3 Oct 2012 19:56:39 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Oct 2012 19:56:32 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q93JuWfk022702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Oct 2012 15:56:32 -0400 Received: from host2.jankratochvil.net (ovpn-116-83.ams2.redhat.com [10.36.116.83]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q93JuR3a020961 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 3 Oct 2012 15:56:30 -0400 Date: Wed, 03 Oct 2012 19:56:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20121003195627.GA17283@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> <20121003184155.03dceed4@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121003184155.03dceed4@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00048.txt.bz2 On Wed, 03 Oct 2012 15:11:55 +0200, Siddhesh Poyarekar wrote: [...] > make 2> build-warnings.out Probably only in gdb/ directory otherwise it would create more needless output to deal with. [...] > I then processed the two files with this wonderful looking command: > > diff -u build-master.out build-bitpos.out | > perl -e 'while(<>){s{^(.)(.*)}{print "$2$1\n"}egm}' | sort | > perl -e 'while(<>){s{^([^\]]+\])(.)$}{print "$2$1\n"}egm}' | > grep "^[-+]" | ./checkreport2.pl | grep -v "^----" | > grep -v "^+++" | grep "^+" | > perl -e \ > 'while(<>){s{^([^\/]+/)+([^:]+:[^:]+):.*}{print "$2\n"}egm}' | > while read loc; do > grep -q "$loc" splint-bitpos3.locdiff.processed This 'grep' has too relaxed search string, for example warnings in "main.c" (there are some 'conversion' warnings) will match _29_ other files creating false FOUND lines and therefore fogetting about possibly valid type safety conversion problems. There should be sure some fgrep -q "($loc:" or so. Thanks, Jan break-interp-main.c dmsym_main.c dw2-cp-infcall-ref-static-main.c dw2-entry-value-main.c dw2-inline-param-main.c dw2-noloc-main.c dw2-param-error-main.c dw2-ref-missing-frame-main.c dw2-unresolved-main.c gcore-relro-main.c gdb1555-main.c jit-dlmain.c jit-main.c main.c mi-main.c mips16-thunks-inmain.c mips16-thunks-main.c mips16-thunks-sinmain.c print-file-var-main.c shmain.c skip-solib-main.c solib-display-main.c solib-list-main.c solib-main.c solib-overlap-main.c solib-symbol-main.c tls-main.c tls-var-main.c type-opaque-main.c