From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6458 invoked by alias); 3 Oct 2012 13:12:54 -0000 Received: (qmail 6250 invoked by uid 22791); 3 Oct 2012 13:12:53 -0000 X-SWARE-Spam-Status: No, hits=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Oct 2012 13:12:42 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q93DCfaB003052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Oct 2012 09:12:41 -0400 Received: from spoyarek (vpn1-4-152.ams2.redhat.com [10.36.4.152]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q93DCaQV011741; Wed, 3 Oct 2012 09:12:37 -0400 Date: Wed, 03 Oct 2012 13:12:00 -0000 From: Siddhesh Poyarekar To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20121003184155.03dceed4@spoyarek> In-Reply-To: <20120930065211.GA21118@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/k/zQiJsP7=wpAA/v6mtb7uy" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00033.txt.bz2 --MP_/k/zQiJsP7=wpAA/v6mtb7uy Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-length: 1603 On Sun, 30 Sep 2012 08:52:11 +0200, Jan wrote: > Or gcc with -Wconversion: > t.c: In function ‘main’: > t.c:5:3: warning: conversion to ‘int’ from ‘long int’ may alter its > value [-Wconversion] t.c:6:24: warning: conversion to ‘int’ from > ‘long int’ may alter its value [-Wconversion] I played around with this briefly today and there seem to be an additional 175 warnings that gcc finds and splint doesn't on x86_64. Here's how I've gone about it: First, I configured gdb as: CC="gcc -Wconversion -Wno-sign-conversion" \ CXX="g++ -Wconversion -Wno-sign-conversion" \ ../gdb.git/configure --enable-targets=all --disable-werror So that I get only the truncation warnings and none of the sign conversion ones. I built the master and bitpos-expand branches (the latter being the one with my patches): make 2> build-warnings.out and then filtered only the "warning: " lines. I then processed the two files with this wonderful looking command: diff -u build-master.out build-bitpos.out | perl -e 'while(<>){s{^(.)(.*)}{print "$2$1\n"}egm}' | sort | perl -e 'while(<>){s{^([^\]]+\])(.)$}{print "$2$1\n"}egm}' | grep "^[-+]" | ./checkreport2.pl | grep -v "^----" | grep -v "^+++" | grep "^+" | perl -e \ 'while(<>){s{^([^\/]+/)+([^:]+:[^:]+):.*}{print "$2\n"}egm}' | while read loc; do grep -q "$loc" splint-bitpos3.locdiff.processed if [ $? -eq 0 ]; then echo "FOUND: $loc" else echo "NOTFOUND: $loc" fi done | grep "^NOTFOUND" The checkreport2.pl is attached. I'll look through this list and see if any of the warnings are relevant. Regards, Siddhesh --MP_/k/zQiJsP7=wpAA/v6mtb7uy Content-Type: application/x-perl Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=checkreport2.pl Content-length: 2912 IyEgL3Vzci9iaW4vcGVybAp1c2Ugc3RyaWN0Owp1c2Ugd2FybmluZ3M7Cgoj IENhbGwgaXQgbGlrZSB0aGlzOgojCiMgZGlmZiAtVS0xIHNwbGludC1iaXRw b3MyLmxvY2RpZmYucHJvY2Vzc2VkIHNwbGludC1iaXRwb3MzLmxvY2RpZmYu cHJvY2Vzc2VkIHwKIyAJZ3JlcCAiXlstK10oIiB8CiMgCXBlcmwgLWUgJ3do aWxlKDw+KXtze14oLikoXChbXjpdKyk6KFswLTldKylcKTooLiopfXtwcmlu dCgiJDIpOiQ0XHRcdCQxJDNcbiIpfWVnbX0nIHwKIyAJc29ydCB8IC4vY2hl Y2tyZXBvcnQucGwKCm15ICgkb2xkX2ZpbGUsICRvbGRfbGluZSwgJG9sZF9j b2wsICRvbGRfc3JjLCAkb2xkX2RzdCwgJG9sZF9uZXcsICRvbGRfKTsKbXkg KCRmaWxlLCAkbGluZSwgJGNvbCwgJHNyYywgJGRzdCwgJG5ldyk7Cm15ICRz dGFydCA9IDE7CgojIFRoZSBleHBlY3RlZCBzZXF1ZW5jZSBpcyBhbHRlcm5h dGl2ZSBvbGQgYW5kIG5ldyB3YXJuaW5nIGxpbmVzIHRoYXQgY29ycmVzcG9u ZAojIHRvIGVhY2ggb3RoZXIgZXhhY3RseSwgZXhjZXB0IGZvciB0aGUgbGlu ZSBudW1iZXJzLiAgT3RoZXIgdGhhbiB0aGF0LCB5b3UgaGF2ZQojIGxpbmVz IHRoYXQgYXJlIG9ubHkgdGhlcmUgaW4gdGhlIG9sZCByZXBvcnQgYW5kIHRo b3NlIHRoYXQgYXJlIG9ubHkgdGhlcmUgaW4KIyB0aGUgbmV3IHJlcG9ydC4g IFRoZSBvbmVzIG9ubHkgaW4gdGhlIG9sZCByZXBvcnQgY2FuIGJlIHJlbW92 ZWQgd2hpbGUgdGhlIG9uZXMKIyBpbiB0aGUgbmV3IHJlcG9ydCBuZWVkIHRv IGJlIHByaW50ZWQgZm9yIHByb2Nlc3NpbmcuCiMKIyBBbmQgdGhlbiB0aGVy ZSBhcmUgdGhvc2UgdGhhdCBhcmUgYWx0ZXJuYXRpbmcsIGJ1dCB0aGV5IGFy ZSBub3QgdGhlIHNhbWUKIyB3YXJuaW5nLiAgSW4gdGhhdCBjYXNlIHdlIHBy aW50IGJvdGggdGhlIG9sZCBhcyB3ZWxsIGFzIHRoZSBuZXcgbGluZXMuCgpM SU5FOiB3aGlsZSAoPFNURElOPikgewoJc3soXi4pKFteOl0rKTooW146XSsp OihbXjpdKyk6IHdhcm5pbmc6IGNvbnZlcnNpb24gdG8g4oCYKFte4oCZXSsp 4oCZIGZyb20g4oCYKFte4oCZXSsp4oCZIG1heSBhbHRlciBpdHMgdmFsdWV9 ewoJCWlmICgkc3RhcnQgZXEgMSkgewoJCQkkb2xkXyA9ICRfOwoJCQkkb2xk X25ldyA9ICQxOwoJCQkkb2xkX2ZpbGUgPSAkMjsKCQkJJG9sZF9saW5lID0g JDM7CgkJCSRvbGRfY29sID0gJDQ7CgkJCSRvbGRfc3JjID0gJDU7CgkJCSRv bGRfZHN0ID0gJDY7CgoJCQkkc3RhcnQgPSAwOwoJCX0KCQllbHNlIHsKCQkJ JG5ldyA9ICQxOwoJCQkkZmlsZSA9ICQyOwoJCQkkbGluZSA9ICQzOwoJCQkk Y29sID0gJDQ7CgkJCSRzcmMgPSAkNTsKCQkJJGRzdCA9ICQ2OwoKCQkJaWYg KCAgICRvbGRfZmlsZSBlcSAkZmlsZQoJCQkgICAgJiYgJG9sZF9jb2wgZXEg JGNvbAoJCQkgICAgJiYgJG9sZF9zcmMgZXEgJHNyYwoJCQkgICAgJiYgJG9s ZF9kc3QgZXEgJGRzdAoJCQkgICAgJiYgJG9sZF9uZXcgbmUgJG5ldykKIwkJ CSAgICAmJiBhYnMoJGxpbmUgLSAkb2xkX2xpbmUpIDwgMTApCgkJCXsKCQkJ CSMgUHJpbnQgdGhlIG5ldyBsaW5lIHdpdGggYSArKysKCQkJCW15ICRkaWZm ID0gJGxpbmUgLSAkb2xkX2xpbmU7CgkJCQlwcmludCAoIisrKygkZGlmZikr KyskXyIpOwoKCQkJCSMgV2UgY29uc3VtZWQgYm90aCBsaW5lcy4KCQkJCSRz dGFydCA9IDE7CgkJCX0KCQkJZWxzZSB7CgkJCQlpZiAoJG9sZF9uZXcgZXEg Jy0nICYmICRuZXcgZXEgJy0nKSB7CgkJCQkJcHJpbnQgKCItLS0tLS0tLS0t LS0tJG9sZF8iKTsKCQkJCX0KCQkJCWVsc2UgewoJCQkJCSMgRWl0aGVyIHRo ZXkgd2VyZSBub3QgY29tcGF0aWJsZSBvcgoJCQkJCSMgd2VyZSBib3RoIG5l dyBjaGFuZ2VzLiAgUHJpbnQgdGhlIG9sZAoJCQkJCSMgb25lIGFuZCBtb3Zl IHRvIG5leHQgbGluZS4KCQkJCQlwcmludCgiJG9sZF9uZXckb2xkX2ZpbGU6 JG9sZF9saW5lOiRvbGRfY29sOiRvbGRfc3JjOiRvbGRfZHN0XG4iKTsKCQkJ CX0KCQkJCSRvbGRfID0gJF87CgkJCQkkb2xkX2ZpbGUgPSAkZmlsZTsKCQkJ CSRvbGRfY29sID0gJGNvbDsKCQkJCSRvbGRfc3JjID0gJHNyYzsKCQkJCSRv bGRfZHN0ID0gJGRzdDsKCQkJCSRvbGRfbmV3ID0gJG5ldzsKCQkJCSRvbGRf bGluZSA9ICRsaW5lOwoJCQl9CgkJfQoKCX1lZ207Cn0K --MP_/k/zQiJsP7=wpAA/v6mtb7uy--