From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15231 invoked by alias); 3 Oct 2012 05:29:55 -0000 Received: (qmail 15211 invoked by uid 22791); 3 Oct 2012 05:29:51 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL,BAYES_40,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Oct 2012 05:29:46 +0000 Received: by padfa10 with SMTP id fa10so6436004pad.0 for ; Tue, 02 Oct 2012 22:29:45 -0700 (PDT) Received: by 10.66.83.8 with SMTP id m8mr2399655pay.48.1349242185603; Tue, 02 Oct 2012 22:29:45 -0700 (PDT) Received: from bubble.grove.modra.org ([101.166.26.37]) by mx.google.com with ESMTPS id nt7sm2045376pbb.33.2012.10.02.22.29.43 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 02 Oct 2012 22:29:45 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 7BA24EA0239; Wed, 3 Oct 2012 14:59:37 +0930 (CST) Date: Wed, 03 Oct 2012 05:29:00 -0000 From: Alan Modra To: Joel Brobecker Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [RFC/RFA] dangling bfd pointer in archive cache... Message-ID: <20121003052937.GB25219@bubble.grove.modra.org> Mail-Followup-To: Joel Brobecker , binutils@sourceware.org, gdb-patches@sourceware.org References: <20121002141405.GD3028@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121002141405.GD3028@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00030.txt.bz2 On Tue, Oct 02, 2012 at 07:14:06AM -0700, Joel Brobecker wrote: > * opncls.c (bfd_close); Add call to _bfd_archive_close_and_cleanup. No, we should already be calling _bfd_archive_close_and_cleanup via > --- a/bfd/opncls.c > +++ b/bfd/opncls.c > @@ -719,6 +719,17 @@ bfd_close (bfd *abfd) > if (! BFD_SEND (abfd, _close_and_cleanup, (abfd))) this call. The problem is in coff-rs6000.c (and coff64-rs6000.c) where the bfd_target vector just uses bfd_true for close_and_cleanup. -- Alan Modra Australia Development Lab, IBM