From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31406 invoked by alias); 1 Oct 2012 19:24:23 -0000 Received: (qmail 31396 invoked by uid 22791); 1 Oct 2012 19:24:22 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Oct 2012 19:24:17 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q91JOAVQ021805; Mon, 1 Oct 2012 21:24:10 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q91JO8Sp010508; Mon, 1 Oct 2012 21:24:08 +0200 (CEST) Date: Mon, 01 Oct 2012 19:24:00 -0000 Message-Id: <201210011924.q91JO8Sp010508@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: markus.t.metzger@intel.com CC: gdb-patches@sourceware.org, markus.t.metzger@gmail.com In-reply-to: (markus.t.metzger@intel.com) Subject: Re: [patch v3 16/16] btrace, x86: restrict to Atom References: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> <1344949171-9545-17-git-send-email-markus.t.metzger@intel.com> <201208141327.q7EDR7TC017727@glazunov.sibelius.xs4all.nl> <201209280239.q8S2ddal001019@glazunov.sibelius.xs4all.nl> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00014.txt.bz2 > From: "Metzger, Markus T" > Date: Fri, 28 Sep 2012 06:51:24 +0000 > > > But I still think putting CPU model specific checks anywhere in GDB is > > wrong. If there are broken kernels out there, figure out a way to > > detect them. > > The cpuid check is simple and reliable. Anything else will be more > complicated and also less straight-forward to understand. But what if btrace support shows up for other CPUs, or if a next generation Atom shows up that has a different cpuid?