From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26088 invoked by alias); 1 Oct 2012 06:14:23 -0000 Received: (qmail 26078 invoked by uid 22791); 1 Oct 2012 06:14:22 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Oct 2012 06:14:09 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q916E8eD014708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Oct 2012 02:14:08 -0400 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q916E4Zp013224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 1 Oct 2012 02:14:07 -0400 Date: Mon, 01 Oct 2012 06:14:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20121001061404.GA3444@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> <20121001105048.5e05e4d7@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121001105048.5e05e4d7@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00001.txt.bz2 On Mon, 01 Oct 2012 07:20:48 +0200, Siddhesh Poyarekar wrote: > However, how about committing these patches if > they're correct and then doing a run with -Wconversion? The patches > are kinda unwieldy to maintain like this since it's quite painful > to review the entire thing repeatedly and edit changelogs, etc. Besides, > they should be safe for mainline since expansion of types should not > pose a regression risk. I volunteer to do this of course. I believe the only problem is with ChangeLogs. When your patch is just a proposal it is OK to review it without a ChangeLog, ChangeLog can be written only after its approval when it is like in this case (a) a significant work to write it and (b) it does not benefit the review process or self-review of the patch which in this case it IMO does not. The problem with checking it in partially is that this patch introduces new conversion regressions which were not caught by splint such as: int len1 = TYPE_LENGTH (type); void *address1, *address2; int len2 = len1 + address1 - address2; -> LONGEST len1 = TYPE_LENGTH (type); void *address1, *address2; int len2 = len1 + address1 - address2; After such patch gets checked in we will no longer find we need to expand also LEN2. Sure we cannot check in the type->LENGTH expansion itself due to the same reason. I believe (I may be wrong) there won't be too many new expansions from the -Wconversion re-verification so you could just incrementally update the existing patch incl. its ChangeLog. I am thinking how to review it and I will have to create the patch again anyway otherwise I do not know how to find out the annotations for it. Thanks, Jan