From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15894 invoked by alias); 28 Sep 2012 11:20:41 -0000 Received: (qmail 15865 invoked by uid 22791); 28 Sep 2012 11:20:37 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Sep 2012 11:20:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8SBKSgW011281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 28 Sep 2012 07:20:28 -0400 Received: from host2.jankratochvil.net (ovpn-116-94.ams2.redhat.com [10.36.116.94]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8SBKOHA025423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 28 Sep 2012 07:20:27 -0400 Date: Fri, 28 Sep 2012 11:20:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20120928112024.GC22720@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120927190053.1e7de264@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00679.txt.bz2 Hi Siddhesh, is anywhere FSF GDB GIT commit hash which all this work is for? On Thu, 27 Sep 2012 15:30:53 +0200, Siddhesh Poyarekar wrote: > I have also updated my repository of splint output reports here: > > http://git.siddhesh.in/cgit.cgi/splint.git/ BTW I cannot "git clone" it. Possibly using downloads of each file from this web interface I see no logs or timestamps and there are too many files, most of which are probably no longer worth checking. So far I do not see how to review the patch as it is not annotated which change is for which valid splint warning. Comment from other maintainers is welcome, annotating will take several more weeks of work. Without the annotation the only risk is that some changes are accidentally needless. As "annotation" I call the /^x/ line below: if (info->onstack) { - int n = info->length; + LONGEST n = info->length; xFIXED(Expand n): (xtensa-tdep.c:1886): VARINIT(n): (LONGEST to int) [info->length] CORE_ADDR offset = sp + info->u.offset; But it is also known that the changeset is not absolutely minimal, in some cases the type was extended as it is very unclear the LONGEST type is in fact not needed there and int would be enough. I do not have such example now but IIRC I just left some such extensions without comment as valid ones. Thanks, Jan