From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17043 invoked by alias); 28 Sep 2012 10:16:53 -0000 Received: (qmail 17033 invoked by uid 22791); 28 Sep 2012 10:16:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Sep 2012 10:16:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6612E1C7B86; Fri, 28 Sep 2012 06:16:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XXygzVtUQM1n; Fri, 28 Sep 2012 06:16:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E91621C7B82; Fri, 28 Sep 2012 06:16:46 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1D35AC8052; Fri, 28 Sep 2012 12:16:45 +0200 (CEST) Date: Fri, 28 Sep 2012 10:16:00 -0000 From: Joel Brobecker To: Anton Blanchard Cc: Edjunior Barbosa Machado , "Gustavo, Luis" , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase Message-ID: <20120928101644.GA24956@adacore.com> References: <20120611193326.GN2687@adacore.com> <20120612224515.15bc044d@kryten> <4FD73EB2.3070705@mentor.com> <20120612131650.GP2687@adacore.com> <4FD743FA.4010403@mentor.com> <4FD773F3.1090307@linux.vnet.ibm.com> <20120613104548.416ba64f@kryten> <4FD89CF9.8080503@linux.vnet.ibm.com> <20120613153730.GG18729@adacore.com> <20120716162326.39d83fa5@kryten> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120716162326.39d83fa5@kryten> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00674.txt.bz2 > > Can you just add -I${srcdir}/${subdir} to the compilation flags, > > and then .include "common.inc" instead of gdb.arch/common.inc? > > Sorry for taking so long to respond. I tried that but srcdir wasn't an > absolute path so it failed. Using the existing asm macro was only > saving us a couple of lines so how about we just open code it? I'd rather not. I know it's only a few lines, but I'm sure these files are there for a reason. I think it might have failed because ${srcdir}/${subdir} wasn't the right path. Your testcase is in gdb.arch, so I am guessing that subdir was "gdb.arch". However, your include file is in gdb.asm. So instead, use -I${srcdir}/gdb.asm instead. -- Joel