From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21910 invoked by alias); 25 Sep 2012 15:50:03 -0000 Received: (qmail 21857 invoked by uid 22791); 25 Sep 2012 15:50:01 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Sep 2012 15:49:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D56B21C74EF; Tue, 25 Sep 2012 11:49:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id A9B3N9dMPDbS; Tue, 25 Sep 2012 11:49:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A6C9E1C746D; Tue, 25 Sep 2012 11:49:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E5175C7917; Tue, 25 Sep 2012 17:49:46 +0200 (CEST) Date: Tue, 25 Sep 2012 15:50:00 -0000 From: Joel Brobecker To: KARTHIKVENKATESH BHAT Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419) Message-ID: <20120925154946.GC3010@adacore.com> References: <23221993.126751348580756252.JavaMail.weblogic@epml02> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23221993.126751348580756252.JavaMail.weblogic@epml02> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00555.txt.bz2 Karthik, Thanks for the fix. > +2012-09-25 Karthik Bhat > + > + * alpha-tdep.c (arm_skip_prologue): Extending support for LLVM compiler. Wrong filename. The patch looks good and is OK to commit provided you fix the formatting issue outlined below. Do you have a copyright assignment on file? This patch is small enough that it can be accepted without one, but if you are planing on contributing more changes, having one would become necessary. Let me know if you need to get started on the paperwork. > Index: gdb/arm-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/arm-tdep.c,v > retrieving revision 1.367 > diff -u -p -r1.367 arm-tdep.c > --- gdb/arm-tdep.c 22 Aug 2012 19:47:56 -0000 1.367 > +++ gdb/arm-tdep.c 25 Sep 2012 13:34:54 -0000 > @@ -1400,7 +1400,7 @@ arm_skip_prologue (struct gdbarch *gdbar > if (post_prologue_pc > && (s == NULL > || s->producer == NULL > - || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0)) > + || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0 || strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0)) Please move the addition || condition on the next line, properly aligned with the others. -- Joel