From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3101 invoked by alias); 25 Sep 2012 06:59:15 -0000 Received: (qmail 3093 invoked by uid 22791); 25 Sep 2012 06:59:14 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Sep 2012 06:58:54 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8P6wnWR017273 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Sep 2012 02:58:49 -0400 Received: from host2.jankratochvil.net (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8P6wjoW004457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 25 Sep 2012 02:58:47 -0400 Date: Tue, 25 Sep 2012 06:59:00 -0000 From: Jan Kratochvil To: Khoo Yit Phang Cc: Andreas Schwab , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists Message-ID: <20120925065844.GA6493@host2.jankratochvil.net> References: <21ACC598-F6B4-4117-BA7B-B316414DE9E3@cs.umd.edu> <20120919130040.GA20442@host2.jankratochvil.net> <20120921182637.GA8747@host2.jankratochvil.net> <83y5k3w7es.fsf@gnu.org> <20120921184623.GA12696@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00538.txt.bz2 On Sat, 22 Sep 2012 18:06:43 +0200, Khoo Yit Phang wrote: > > A common idiom is to use !! when the other side is already boolean. > > I like this idiom, it does seem to be used in GDB, and isdir should be > a boolean. Here's a patch that uses it. [...] > + if (stat (path, &s) != 0 || (isdir != !!S_ISDIR (s.st_mode))) Sorry but it is not about what you like (*) but what has been concluded as acceptable for the GDB codebase to keep it (possibly) easily contributable. (*) I also use such constructs in my own code. This is irrelevant here. Thanks, Jan