From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10929 invoked by alias); 24 Sep 2012 20:49:54 -0000 Received: (qmail 10913 invoked by uid 22791); 24 Sep 2012 20:49:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 20:49:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D99C01C6285; Mon, 24 Sep 2012 16:49:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xNgJmfjWD-cT; Mon, 24 Sep 2012 16:49:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 79D811C621B; Mon, 24 Sep 2012 16:49:34 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 56E7ECBC5C; Mon, 24 Sep 2012 22:49:31 +0200 (CEST) Date: Mon, 24 Sep 2012 20:49:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: Khoo Yit Phang , jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Message-ID: <20120924204931.GA4265@adacore.com> References: <20120922110822.GA28159@host2.jankratochvil.net> <78B3333C-92F9-474D-8352-087C5A0F575B@cs.umd.edu> <20120924072945.GA4146@adacore.com> <20120924145910.GE4146@adacore.com> <2878953E-B698-43F3-989A-A551D96BAB62@cs.umd.edu> <20120924152641.GF4146@adacore.com> <9F52A338-A158-44DC-90C1-F46503859613@cs.umd.edu> <285502C6-1395-4049-9D55-031EDA3AD06D@cs.umd.edu> <83haqni93s.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83haqni93s.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00526.txt.bz2 > > > A simpler alternative would be to detect if the gdb_program_name > > > == $BUILDDIR/gdb/gdb, then only look for > > > $BUILDDIR/gdb/data-directory. It would still hard code parts of > > > the build directory into the binary (i.e., make sure you don't > > > have any embarrassing/privacy-leaking paths in your home directory > > > structure), but would much lessen the risk of a stray > > > data-directory. What do you think? > > > > Here's yet another alternative: gdb already tries to locate > > data-directory in $BUILDDIR/share/gdb as part of the relocation > > logic; we can install a symlink there that points to > > $BUILDDIR/gdb/data-directory, or make a copy for platforms that > > don't support symlinks. > > I liked the first of these two better. It is simpler. I am not sure it is simpler, because I don't think that the GDB binary knows what the $BUILDDIR was. I am also wondering whether we might activate the in-true use feature by accident too. I like the second suggestion because it's very simple (as you could see from the patch), and avoids touching the behavior in the installed-case. In other words, our requirement does not affect the behavior at the end-user level. -- Joel