From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3988 invoked by alias); 24 Sep 2012 16:40:49 -0000 Received: (qmail 3902 invoked by uid 22791); 24 Sep 2012 16:40:47 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 16:40:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1E9441C6EFD; Mon, 24 Sep 2012 12:40:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LxiqVS0lnL5c; Mon, 24 Sep 2012 12:40:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E655D1C6DE1; Mon, 24 Sep 2012 12:40:33 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DC5EACCCE8; Mon, 24 Sep 2012 18:40:21 +0200 (CEST) Date: Mon, 24 Sep 2012 16:40:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] Delete unused functions in sol-thread.c. Message-ID: <20120924164021.GH4146@adacore.com> References: <1348158841-2313-1-git-send-email-brobecker@adacore.com> <1348158841-2313-5-git-send-email-brobecker@adacore.com> <505B52EA.5080908@redhat.com> <20120920214340.GB5423@adacore.com> <506087DE.5090900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506087DE.5090900@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00516.txt.bz2 > There's more '#if 0'-related code in the file. I think that if we're > removing these, we should get rid of all of it. I'll take care of those too... > I found it curious that > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc_db/common/thread_db.c > says "Currently unused by dbx"... That might explain why it's OK to do nothing inside these routines... -- Joel