From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2549 invoked by alias); 24 Sep 2012 08:12:41 -0000 Received: (qmail 2528 invoked by uid 22791); 24 Sep 2012 08:12:38 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO,TW_BJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 08:12:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F3EDD1C7869; Mon, 24 Sep 2012 04:12:24 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Aw1NDEwJPvYf; Mon, 24 Sep 2012 04:12:24 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4D3491C778F; Mon, 24 Sep 2012 04:12:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4A762CCCA9; Mon, 24 Sep 2012 10:12:20 +0200 (CEST) Date: Mon, 24 Sep 2012 08:12:00 -0000 From: Joel Brobecker To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Fix http://sourceware.org/bugzilla/show_bug.cgi?id=14550 Message-ID: <20120924081220.GB4146@adacore.com> References: <1348462325-4891-1-git-send-email-sanjoy@playingwithpointers.com> <1348462325-4891-2-git-send-email-sanjoy@playingwithpointers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1348462325-4891-2-git-send-email-sanjoy@playingwithpointers.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00489.txt.bz2 Just a request (it's OK to refuse): Can we use a different subject for this patch? The problem with the current subject is that, when you review the list of changes (git log), the subject isn't really helpful in figuring out what the patch is about. Thanks! On Mon, Sep 24, 2012 at 10:22:03AM +0530, Sanjoy Das wrote: > --- > gdb/ChangeLog | 7 +++++++ > gdb/jit.c | 14 ++++++++++++-- > 2 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 0b1d771..13eaa5c 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,10 @@ > +2012-09-24 Sanjoy Das > + > + PR gdb/14550 > + > + * jit.c (finalize_symtab): Ensure that only the global block has a > + NULL superblock. > + > 2012-09-22 Yao Qi > > * remote.c (remote_get_trace_status): Remove setting default > diff --git a/gdb/jit.c b/gdb/jit.c > index 9e8f295..eff2ed6 100644 > --- a/gdb/jit.c > +++ b/gdb/jit.c > @@ -724,8 +724,18 @@ finalize_symtab (struct gdb_symtab *stab, struct objfile *objfile) > gdb_block_iter = gdb_block_iter->next) > { > if (gdb_block_iter->parent != NULL) > - BLOCK_SUPERBLOCK (gdb_block_iter->real_block) = > - gdb_block_iter->parent->real_block; > + { > + /* If the plugin specifically mentioned a parent block, we > + use that. */ > + BLOCK_SUPERBLOCK (gdb_block_iter->real_block) = > + gdb_block_iter->parent->real_block; > + } > + else > + { > + /* And if not, we set a default parent block. */ > + BLOCK_SUPERBLOCK (gdb_block_iter->real_block) = > + BLOCKVECTOR_BLOCK (symtab->blockvector, STATIC_BLOCK); > + } > } > > /* Free memory. */ > -- > 1.7.10.4 -- Joel