Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: gdb-patches@sourceware.org
Subject: [obv][commit] Eliminate a single-use variable in eval.c
Date: Fri, 21 Sep 2012 09:27:00 -0000	[thread overview]
Message-ID: <20120921145611.0dc0d21d@spoyarek> (raw)

Hi,

I have committed another small change that eliminates a local
variable that is used only once in the function with the direct function
call.  This is an attempt to make the changes for 64-bit struct offset
and length smaller.  For a context on those changes, please refer:

http://sourceware.org/ml/gdb-patches/2012-08/msg00144.html

Regards,
Siddhesh

http://sourceware.org/ml/gdb-cvs/2012-09/msg00117.html

Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14683
diff -u -r1.14683 ChangeLog
--- gdb/ChangeLog	21 Sep 2012 01:46:39 -0000	1.14683
+++ gdb/ChangeLog	21 Sep 2012 09:23:17 -0000
@@ -1,3 +1,8 @@
+2012-09-21  Siddhesh Poyarekar  <siddhesh@redhat.com>
+
+	* eval.c (evaluate_subexp_standard): Eliminate single-use
+	variable LOWER.
+
 2012-09-21  Yao Qi  <yao@codesourcery.com>
 
 	* mi/mi-interp.c: Declare mi_record_changed.
Index: gdb/eval.c
===================================================================
RCS file: /cvs/src/src/gdb/eval.c,v
retrieving revision 1.171
diff -u -r1.171 eval.c
--- gdb/eval.c	16 Aug 2012 07:36:19 -0000	1.171
+++ gdb/eval.c	21 Sep 2012 09:23:18 -0000
@@ -810,7 +810,6 @@
   struct type *type;
   int nargs;
   struct value **argvec;
-  int lower;
   int code;
   int ix;
   long mem_offset;
@@ -2370,8 +2369,8 @@
 	    struct type *array_type = check_typedef (value_type (array));
 	    LONGEST index = subscript_array[i - 1];
 
-	    lower = f77_get_lowerbound (array_type);
-	    array = value_subscripted_rvalue (array, index, lower);
+	    array = value_subscripted_rvalue (array, index,
+					      f77_get_lowerbound (array_type));
 	  }
 


                 reply	other threads:[~2012-09-21  9:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120921145611.0dc0d21d@spoyarek \
    --to=siddhesh@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox