From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31016 invoked by alias); 20 Sep 2012 22:25:08 -0000 Received: (qmail 31006 invoked by uid 22791); 20 Sep 2012 22:25:07 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Sep 2012 22:24:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EF69B1C74D2; Thu, 20 Sep 2012 18:24:49 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id E-2qCg7g8VcD; Thu, 20 Sep 2012 18:24:49 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C10A81C7254; Thu, 20 Sep 2012 18:24:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 50A5ECC175; Thu, 20 Sep 2012 15:24:47 -0700 (PDT) Date: Thu, 20 Sep 2012 22:25:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] Delete unused functions in sol-thread.c. Message-ID: <20120920222447.GC5423@adacore.com> References: <1348158841-2313-1-git-send-email-brobecker@adacore.com> <1348158841-2313-5-git-send-email-brobecker@adacore.com> <505B52EA.5080908@redhat.com> <20120920214340.GB5423@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120920214340.GB5423@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00417.txt.bz2 > And the next step I propose, to finish the work, is to move these > functions to their own file (sol-sparc-thread.c). We would then > only build that file for sparc-solaris native GDB. And attached is the final step. I can merge all 3 patches into a single delete-commented-out-code-and-move-to-sol-sparc-thread patch. Either way works for me. Tested on both x86-solaris (2.10) and sparc-solaris (2.9). How does it look? Thanks, -- Joel