> Can you expand on what "unused" means?

Good question!

> The Solaris man page I peeked at says these functions are SPARC only.
> Does this mean that current SPARC Solaris libthread_db doesn't call them
> after all?  What about older versions?

It took me a while to investigate this part because our sparc-solaris
machines are just sooooo sloooooowwww. Initially, I thought it might
have been something related to OS versions, but the answer was right
there in front of me, if I had tested the patch on *sparc* solaris
(in addition to *x86* solaris).

Basically, /usr/include/proc_service.h:

    #if defined(__sparc) || defined(__sparcv9)
    extern ps_err_e ps_lgetxregsize(struct ps_prochandle *, lwpid_t, int *);
    extern ps_err_e ps_lgetxregs(struct ps_prochandle *, lwpid_t, caddr_t);
    extern ps_err_e ps_lsetxregs(struct ps_prochandle *, lwpid_t, caddr_t);
    #endif

In other words, these routines are used on sparc-solaris, while they
are not expected on x86-solaris.

I propose we start with the following patch (0001-[...].patch),
and while at it, we remove all the commented out code (0002-[...]).
This is a stop-gap measure to allow the build to work with -Werror
on x86-solaris.

And the next step I propose, to finish the work, is to move these
functions to their own file (sol-sparc-thread.c). We would then
only build that file for sparc-solaris native GDB.

WDYT?

Thanks,
-- 
Joel