From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94645-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19452 invoked by alias); 18 Sep 2012 17:20:23 -0000
Received: (qmail 19438 invoked by uid 22791); 18 Sep 2012 17:20:21 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO,TW_CP
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 17:20:08 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 97B281C71E4;	Tue, 18 Sep 2012 13:20:07 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id tdjUqKWfRZ7K; Tue, 18 Sep 2012 13:20:07 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 42C781C7049;	Tue, 18 Sep 2012 13:20:07 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id B50BBCAE07; Tue, 18 Sep 2012 10:20:02 -0700 (PDT)
Date: Tue, 18 Sep 2012 17:20:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gdb-patches@sourceware.org, Kevin Buettner <kevinb@redhat.com>
Subject: Re: SH: double pseudo registers little-endian/big-endian
Message-ID: <20120918172002.GE3276@adacore.com>
References: <87zk5cjs1n.fsf@schwinge.name> <87d31y9rg7.fsf@schwinge.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d31y9rg7.fsf@schwinge.name>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00368.txt.bz2

Hi Thomas,

Sorry for the delay in reviewing this.

> > gdb/
> > 	sh-tdep.c (sh_register_convert_to_virtual)
> > 	(sh_register_convert_to_raw): Add a gdbarch parameter.  Update
> > 	all callers.  Just do a memcpy if not the little-endian case.

This patch looks OK to me. Please go ahead and commit.

-- 
Joel