From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3595 invoked by alias); 17 Sep 2012 16:57:03 -0000 Received: (qmail 3576 invoked by uid 22791); 17 Sep 2012 16:57:00 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Sep 2012 16:56:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8HGufWQ003601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 17 Sep 2012 12:56:41 -0400 Received: from host2.jankratochvil.net (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8HGubf2025981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 17 Sep 2012 12:56:40 -0400 Date: Mon, 17 Sep 2012 16:57:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: PATCH: error reading variable: value has been optimized out Message-ID: <20120917165636.GA25759@host2.jankratochvil.net> References: <50376F3B.1080407@broadcom.com> <20120826171840.GA21205@host2.jankratochvil.net> <504092C0.2000602@broadcom.com> <87wqzz5eug.fsf@fleche.redhat.com> <5051D2A7.2000009@broadcom.com> <87r4q4zav8.fsf@fleche.redhat.com> <5053A419.1090009@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5053A419.1090009@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00317.txt.bz2 On Fri, 14 Sep 2012 23:39:37 +0200, Andrew Burgess wrote: > On 14/09/2012 8:02 PM, Tom Tromey wrote: > >Andrew> + # If we ever fix gdb so this passes we should delete the > >Andrew> + # unsupported case below. > >Andrew> + xpass $test > > > >Andrew> + unsupported $test > > > >I think these tests should 'pass' if they generate the correct output, > >and 'kfail' otherwise. I agree with Tom here. There are ongoing disputes how to mark testsuite results as it is more a matter of opinion, so I do not want much to argue about anything. Also I am not sure if I wrote it below so that it can be well understood. > But if they kfail then they need a defect ID, it seems rather > pointless to raise a defect for unsupported behaviour we have no > intention to fix. Not everything may be perfect but it is the current practice to do it that way. > Surely xpass is the right choice. 'xpass' is OK. But that 'pass' is not right, we know GDB could behave better (*). 'kfail' is for the 'pass' state more appropriate as we know GDB has a (theoretical) problem. (*) It is not important here whether it is worth the effort which it is not. XPASS A pleasant kind of failure: a test was expected to fail, but succeeded. This may indicate progress; inspect the test case to determine whether you should amend it to stop expecting failure. > If the test ever does pass I hope > the unexpected pass result will draw attention to the test so the > "unsupported" (or kfail) can be removed. If it was just a pass then > there's a chance the test could be fixed then regress and we'd never > notice as the unsupported (or kfail) would never have been removed. 'unsupported' should not apply in any of these cases as it is about the testing environment. But all these testcases do not depend on anything in system. UNSUPPORTED A test depends on a conditionally available feature that does not exist (in the configured testing environment). For example, you can use this outcome to report on a test case that does not work on a particular target because its operating system support does not include a required subroutine. Thanks, Jan