Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)

Jan Kratochvil
2012-09-21T19:52:07Z

On Fri, 21 Sep 2012 21:39:54 +0200, Tom Tromey wrote:
> At least from the patch it appears that the comment is over by the
> leftmost column, but I think the comment should be indented like the
> code is.

This is after patch from the mail, grep -3 xxx | expand, inserted into this
mail.

I see it has 81 columns but with the large tabs there this file has very
common violation of > 80 columns; I can fix this patch, though.

Thanks,
Jan

------------------------------------------------------------------------------

operator : OPERATOR NEW
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = make_operator ("new", 3);
}
| OPERATOR DELETE
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = make_operator ("delete ", 1);
}
| OPERATOR NEW '[' ']'
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = make_operator ("new[]", 3);
}
| OPERATOR DELETE '[' ']'
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = make_operator ("delete[] ", 1);
}
--

exp : SIZEOF '(' type ')' %prec UNARY
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = d_unary ("sizeof ", $3);
}