Re: [patch] gdb.base/valgrind-infcall.exp compat. with Ubuntu 10.04.4

Pedro Alves
2012-08-21T18:41:37Z

On 08/21/2012 07:27 PM, Jan Kratochvil wrote:
> On Tue, 21 Aug 2012 20:19:55 +0200, Pedro Alves wrote:
>> On 08/07/2012 07:43 AM, Jan Kratochvil wrote:
>>> set continue_count 1
>>> -while 1 {
>>> +set loop 1
>>> +while {$loop} {
>>> set test "continue #$continue_count"
>>> gdb_test_multiple "continue" "" {
>>> -re "Invalid free\\(\\).*: main .*\r\n$gdb_prompt $" {
>>> pass $test
>>> - break
>>> + # In Ubuntu 10.04.4 environments 'break' does not work here.
>>> + set loop 0
>>> }
>>
>> For archaeology, and for knowing when can we stop caring for this issue,
>> it would be nice(r) IMO to know the tcl/expect version that triggered this issue.
>
> This was "v1" patch, there is also "patchv2".
>
> "patchv2" fixes also the case of "The program is not being run". I believe
> the Doug's problem was due to it and not due to the "break" statement. But
> I failed to reproduce the Doug's problem so I left it as is.
>
> The comment just states the bugreport, nothing more.

Understood. The comment is still there on v2, so the point still stands
though.

--
Pedro Alves