Re: Testsuite regression gdb.cp/converts.exp [Re: [RFA] gdb/13483]

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Wed, 12 Sep 2012 21:38:12 +0200, Keith Seitz wrote:
> On 09/10/2012 10:45 PM, Jan Kratochvil wrote:
> >on CentOS-5:
> >
> >  Running gdb/testsuite/gdb.cp/converts.exp ...
> >-PASS: gdb.cp/converts.exp: continue to breakpoint: end of main
> >[...]
> >-PASS: gdb.cp/converts.exp: p foo3_2 (1,1)
> >+gdb compile failed, gdb/testsuite/gdb.cp/converts.cc: In function 'int main()':
> >+gdb/testsuite/gdb.cp/converts.cc:81: warning: the address of 'int foo1_7(bool)', will always evaluate as 'true'
> >+UNTESTED: gdb.cp/converts.exp: converts.exp
> 
> My guess is an older compiler. Since none of these function calls is
> really necessary (well, one probably is necessary to make sure
> foo1_7 isn't optimized away), I propose just deleting the offending
> line.

Yes, I agree.  Although rather to replace it in .c by an explanatory comment
like

/* .exp file contains line
     gdb_test "p foo1_7(&foo1_7)" " = 17"
   which is not compiled here for verification as older GCCs (~4.1) fail the
   compilation due to:
     warning: the address of 'int foo1_7(bool)', will always evaluate as 'true'
   */
  

Thanks,
Jan