From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94497-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23030 invoked by alias); 12 Sep 2012 18:10:51 -0000
Received: (qmail 23001 invoked by uid 22791); 12 Sep 2012 18:10:50 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Sep 2012 18:10:37 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8CI9wvP020499	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 12 Sep 2012 14:09:58 -0400
Received: from tranklukator.brq.redhat.com (dhcp-1-232.brq.redhat.com [10.34.1.232])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id q8CI9tLg006434;	Wed, 12 Sep 2012 14:09:56 -0400
Received: by tranklukator.brq.redhat.com (nbSMTP-1.00) for uid 500	oleg@redhat.com; Wed, 12 Sep 2012 20:12:13 +0200 (CEST)
Date: Wed, 12 Sep 2012 18:10:00 -0000
From: Oleg Nesterov <oleg@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: srikar@linux.vnet.ibm.com, Ingo Molnar <mingo@elte.hu>,        Peter Zijlstra <peterz@infradead.org>,        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,        Roland McGrath <roland@hack.frob.com>, linux-kernel@vger.kernel.org,        gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] uprobes: add global breakpoints
Message-ID: <20120912181210.GA11122@redhat.com>
References: <1347377843-16017-1-git-send-email-bigeasy@linutronix.de> <1347377843-16017-2-git-send-email-bigeasy@linutronix.de> <20120912143010.GA1447@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120912143010.GA1447@redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00220.txt.bz2

On 09/12, Oleg Nesterov wrote:
>
> Lets start with the patch below,
> ...
>
> -	if (!(uprobe->flags & UPROBE_SKIP_SSTEP))
> +	if (!(uprobe->flags & UPROBE_SKIP_SSTEP) || (action & UPROBE_RESTART))

Hmm. This is wrong, but only because handle_swbp() is buggy.
I'll send the fix tomorrow.

Oleg.