From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8824 invoked by alias); 12 Sep 2012 13:19:30 -0000 Received: (qmail 8765 invoked by uid 22791); 12 Sep 2012 13:19:29 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Sep 2012 13:19:11 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8CDJ8cD022467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Sep 2012 09:19:08 -0400 Received: from host2.jankratochvil.net (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8CDJ4rl010990 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 12 Sep 2012 09:19:06 -0400 Date: Wed, 12 Sep 2012 13:19:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: Tom Tromey , Doug Evans , gdb-patches@sourceware.org Subject: Re: [RFC] Don't allow setting register in non-innermost frame Message-ID: <20120912131901.GA1831@host2.jankratochvil.net> References: <1345170040-25959-1-git-send-email-yao@codesourcery.com> <87hartpodt.fsf@fleche.redhat.com> <20120907164544.GA18234@host2.jankratochvil.net> <504D49DA.6070006@codesourcery.com> <87ehm8a3gg.fsf@fleche.redhat.com> <504FDC49.5090806@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <504FDC49.5090806@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00194.txt.bz2 On Wed, 12 Sep 2012 02:50:17 +0200, Yao Qi wrote: > I also realize that this patch becomes "unnatural" :) so I drop it. > I'll revisit it when we do have the need to fix this problem. The test > case is still useful, as we don't have test for setting registers in > testsuite. Is the test case OK? In such case could it be more arch-independent? It could either use register int var; and 'info addr var' to set that register, independently of arch. Or it could 'info reg' and also set some of the register(s) printed. Currently the testcase seems pretty complicated to me for a single 'set $reg=num' test. Thanks, Jan