From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7639 invoked by alias); 10 Sep 2012 19:43:42 -0000 Received: (qmail 7630 invoked by uid 22791); 10 Sep 2012 19:43:42 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Sep 2012 19:43:27 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8AJhONO005955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Sep 2012 15:43:24 -0400 Received: from host2.jankratochvil.net (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8AJhK7M020501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 10 Sep 2012 15:43:23 -0400 Date: Mon, 10 Sep 2012 19:43:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: Tom Tromey , Doug Evans , gdb-patches@sourceware.org Subject: Re: [RFC] Don't allow setting register in non-innermost frame Message-ID: <20120910194319.GA30139@host2.jankratochvil.net> References: <1345170040-25959-1-git-send-email-yao@codesourcery.com> <87hartpodt.fsf@fleche.redhat.com> <20120907164544.GA18234@host2.jankratochvil.net> <504D49DA.6070006@codesourcery.com> <20120910074639.GA26588@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120910074639.GA26588@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00137.txt.bz2 On Mon, 10 Sep 2012 09:46:39 +0200, Jan Kratochvil wrote: > I understand you are more concerned with MI but if I read correctly MI will > answer it as 'y', unaware whether the query message gets propagated to your MI > frontend so maybe you would like: > > if (query (_("Really assign to stored register in non-innermost frame? "))) > warning (_("Assigning to register in non-innermost frame.")); > else > error (_("Not confirmed.")); or to prevent double-warning in CLI mode: if (!query (_("Really assign to stored register in non-innermost frame? "))) error (_("Not confirmed.")); else if (ui_out_is_mi_like_p (uiout)) warning (_("Assigning to register in non-innermost frame.")); Thanks, Jan