Re: bitpos expansion patches summary

Siddhesh Poyarekar
2012-08-17T09:35:31Z

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Hi,

Here is an updated patch for the missed expansions. This should apply
on top of the bitpos expansion patch. I have verified that the patch
does not cause any regressions in the testsuite on x86_64. I have also
run splint and the perl scripts to see if I have missed any more.

Regards,
Siddhesh

gdb/ChangeLog:

* ada-lang.c (ada_value_primitive_packed_val): Expand NEW_OFFSET
to LONGEST.
* arm-tdep.c (arm_vfp_cprc_sub_candidate): Expand COUNT to
LONGEST.
* dwarf2loc.c (indirect_pieced_value): Expand THIS_SIZE_BITS to
LONGEST.
* sh-tdep.c (sh_push_dummy_call_fpu): Expand REG_SIZE to
ssize_t.
(sh_push_dummy_call_nofpu): Likewise.

[-- Attachment #2: bitpos-expand-missed-expand.patch --]
[-- Type: text/x-patch, Size: 1757 bytes --]

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index c350a0e..9c305702 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -2312,7 +2312,7 @@ ada_value_primitive_packed_val (struct value *obj, const gdb_byte *valaddr,

if (obj != NULL)
{
- long new_offset = offset;
+ LONGEST new_offset = offset;

set_value_component_location (v, obj);
set_value_bitpos (v, bit_offset + value_bitpos (obj));
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index dc587e1..496cc30 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -3427,7 +3427,7 @@ arm_vfp_cprc_sub_candidate (struct type *t,

case TYPE_CODE_STRUCT:
{
- int count = 0;
+ LONGEST count = 0;
unsigned unitlen;
int i;
for (i = 0; i < TYPE_NFIELDS (t); i++)
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index ad12e37..bef4355 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -1995,7 +1995,7 @@ indirect_pieced_value (struct value *value)
for (i = 0; i < c->n_pieces && bit_length > 0; i++)
{
struct dwarf_expr_piece *p = &c->pieces[i];
- size_t this_size_bits = p->size;
+ ULONGEST this_size_bits = p->size;

if (bit_offset > 0)
{
diff --git a/gdb/sh-tdep.c b/gdb/sh-tdep.c
index 00d7401..1f599f8 100644
--- a/gdb/sh-tdep.c
+++ b/gdb/sh-tdep.c
@@ -1068,7 +1068,7 @@ sh_push_dummy_call_fpu (struct gdbarch *gdbarch,
CORE_ADDR regval;
char *val;
LONGEST len;
- int reg_size = 0;
+ ssize_t reg_size = 0;
int pass_on_stack = 0;
int treat_as_flt;
int last_reg_arg = INT_MAX;
@@ -1210,7 +1210,7 @@ sh_push_dummy_call_nofpu (struct gdbarch *gdbarch,
CORE_ADDR regval;
char *val;
LONGEST len;
- int reg_size = 0;
+ ssize_t reg_size = 0;
int pass_on_stack = 0;
int last_reg_arg = INT_MAX;