Re: bitpos expansion patches summary

Siddhesh Poyarekar
2012-08-13T14:04:28Z

On Mon, 13 Aug 2012 15:49:15 +0200, Jan wrote:
> I was requesting only to remove the redundant line
> avr-tdep.c:1298:ensure_type_fits_sizet (type);
>

OK, will do.

> ensure_type_fits_sizet uses only TYPE->LENGTH so it does not need to
> be passed TYPE at all. It would make sense if ensure_type_fits_sizet
> prints TYPE_NAME in the error case etc. - but it does not use
> TYPE_NAME anyway..

Sure, I can do that.

> > Likewise for other tdep instances.
>
> I do not see how it can be generalized, I may not just see what do
> you mean.

I meant the other instances that you pointed out as unnecessary -
sorry for the confusion.

> > > (breakpoint.c:4624): FUNC(): (LONGEST to int)
> > > [loc->length]
> > > - That's not true, s390x can set arbitrary hardware watchpoint
> > > memory range, see s390_fix_watch_points. WPFIXED(Expand
> >
> > Oh, then my assumption about watchpoint sizes would be wrong then
> > wouldn't it? We then need to expand the ok_for_watchpoint as well as
> > {insert|remove}_watchpoint. We could do it as a different changeset
> > since only s390x would need it.
>
> You are right. Sorry I did not remember this s390x feature when we
> discussed it before.

No worries, I'll work on the watchpoint change once we get the rest of
the stuff in if it is OK. Not having it in this change itself is not
going to break something that is not already broken.

Regards,
Siddhesh