Re: bitpos expansion patches summary

Jan Kratochvil
2012-08-08T22:43:37Z

Hi Siddhesh,

I have found one problem. We miss the cases (there won't be too many) like:

ada-lang.c:2315
offset is LONGEST:
long new_offset = offset;

As on x86_64 LONGEST is #defined as 'long'. But on LLP64 (MS-Windows IA64)
http://en.wikipedia.org/wiki/64-bit#64-bit_data_models
'long' is 32-bit but LONGEST is (presumably) still 64-bit.

'long' should be changed to 'LONGEST' at ada-lang.c:2315.

It probably requires to run splint also in 32-bit mode (on GNU/Linux).

Thanks,
Jan