From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26647 invoked by alias); 27 Aug 2012 14:02:49 -0000 Received: (qmail 26636 invoked by uid 22791); 27 Aug 2012 14:02:48 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Aug 2012 14:02:33 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7RE2W1r025935 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Aug 2012 10:02:32 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7RE2S4h011482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 27 Aug 2012 10:02:31 -0400 Date: Mon, 27 Aug 2012 14:02:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: bitpos expansion patches summary Message-ID: <20120827140228.GA7178@host2.jankratochvil.net> References: <20120805005350.150e5b74@spoyarek> <20120826174335.GA23917@host2.jankratochvil.net> <20120827133927.2356a430@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120827133927.2356a430@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00799.txt.bz2 On Mon, 27 Aug 2012 10:09:27 +0200, Siddhesh Poyarekar wrote: > On Sun, 26 Aug 2012 19:43:35 +0200, Jan wrote: > > (i386-nat.c:613): > > FUNC(i386_length_and_rw_bits): (LONGEST to int) [len] > > - To be re-checked with updated watchpoints patch. > > This is safe, since ok_for_watchpoint will restrict the incoming LEN in > insert_watchpoint. > > > WPREVERTED(Likewise): (i386-nat.c:647): > > FUNC(i386_length_and_rw_bits): (LONGEST to int) [len] > > - To be re-checked with updated watchpoints patch. > > Likewise for remove_watchpoint. OK, I agree with these two, these are already i386-specific and i386 (contrary to s390) has very limited maximum span of a single hardward watchpoint. > Yes, all of the ENSURED_SIZET for -tdep have been removed for similar > reasons. It will be fun to merge all the pending patches and reviews in the end. > > SAFE: > > (mdebugread.c:1238): ASSIGN: (bfd_vma to > > LONGEST) [ ((*f).loc.bitpos) = (sh->value)] > > - Not so clear to me, --disable-64-bit-bfd cannot support >=2GB > > inferiors but it should support >256MB structs. Still when it also > > affects only STABS I do not think it needs a fix. > > Either ways, the point is that sizeof (bfd_vma) would always be less or > equal to than sizeof (LONGEST) and hence this ought to be safe. OK, I agree, I have mistaken my review here. Thanks, Jan