From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19083 invoked by alias); 27 Aug 2012 13:07:05 -0000 Received: (qmail 18923 invoked by uid 22791); 27 Aug 2012 13:07:04 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Aug 2012 13:06:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7RD6kpu025152 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 27 Aug 2012 09:06:46 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7RD6gHR031786 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 27 Aug 2012 09:06:45 -0400 Date: Mon, 27 Aug 2012 13:07:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Remove pass in skip_unwinder_tests Message-ID: <20120827130641.GA5592@host2.jankratochvil.net> References: <877gt1zbr5.fsf@fleche.redhat.com> <1345715389-20955-1-git-send-email-yao@codesourcery.com> <1345715389-20955-2-git-send-email-yao@codesourcery.com> <20120824133738.GB5219@host2.jankratochvil.net> <5037A087.1090703@redhat.com> <20120824161854.GA10953@host2.jankratochvil.net> <503B4CF7.5090509@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <503B4CF7.5090509@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00798.txt.bz2 On Mon, 27 Aug 2012 12:33:27 +0200, Yao Qi wrote: > On 08/25/2012 12:18 AM, Jan Kratochvil wrote: > >If the system does not have unwinder hook it will XFAIL. XFAIL is not even > >displayed on screen during interactive run. > > If we do a gdb test, and test is failed because of the misbehaviour, > we should use XFAIL. What is "misbehavior" here? > However, in proc 'skip_XXX' in lib/gdb.exp, we > check the supported feature of system instead of doing a gdb test, > so no PASS/FAIL/XFAIL should be emitted. XFAIL is for "unsupported system feature". What does XFAIL mean different than "unsupported system feature"? When will ever be XFAIL emitted if not for "unsupported system feature"? THanks, Jan