From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1031 invoked by alias); 24 Aug 2012 14:28:11 -0000 Received: (qmail 1012 invoked by uid 22791); 24 Aug 2012 14:28:09 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 14:27:52 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7OERpIP003016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 24 Aug 2012 10:27:51 -0400 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7OERkXD008268 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 24 Aug 2012 10:27:49 -0400 Date: Fri, 24 Aug 2012 14:28:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] gdb.base/valgrind-infcall.exp compat. with Ubuntu 10.04.4 Message-ID: <20120824142733.GA5887@host2.jankratochvil.net> References: <20120807064303.GA4739@host2.jankratochvil.net> <5033D14B.4090801@redhat.com> <20120821182731.GA2980@host2.jankratochvil.net> <5033D64E.1020106@redhat.com> <20120821190428.GA3994@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00724.txt.bz2 --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 835 On Tue, 21 Aug 2012 22:00:44 +0200, Doug Evans wrote: > I'd say keep the comment in some form. > > The tcl/expect I've been using is > $ expect -v > expect version 5.44.1.14 > $ ldd /usr/bin/expect | grep tcl > libtcl8.5.so.0 => /usr/lib/libtcl8.5.so.0 (0x00007ff9bac15000) After reverting 61ab2e32245eadc40c36c5d7d4c4962962df59bd on FSF GDB HEAD it still works for me. expect-5.44.1.14-0google.fc18.x86_64 tcl-8.5.12-1.fc18.x86_64 Built from Fedora 18 expect repository http://pkgs.fedoraproject.org/cgit/expect.git/tree/?h=f18&id=751b103fb1c95b705fd8a2eb9cf5c682f0aef373 by attached .spec patch with: https://launchpad.net/ubuntu/+archive/primary/+files/expect_5.44.1.14.orig.tar.gz Do you run some replaced valgrind on updated Ubuntu 10.04.4? Stock Ubuntu valgrind is too old for this testcase to run. Regards, Jan --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="expect.spec-google.patch" Content-length: 2663 diff --git a/expect.spec b/expect.spec index 60dcb5c..1ff01e4 100644 --- a/expect.spec +++ b/expect.spec @@ -1,16 +1,17 @@ +%global _unpackaged_files_terminate_build 0 %{!?tcl_version: %define tcl_version %(echo 'puts $tcl_version' | tclsh)} %{!?tcl_sitearch: %define tcl_sitearch %{_libdir}/tcl%{tcl_version}} -%global majorver 5.45 +%global majorver 5.44.1.14 Summary: A program-script interaction and testing utility Name: expect Version: %{majorver} -Release: 7%{?dist} +Release: 0google%{?dist} License: Public Domain Group: Development/Languages # URL: probably more useful is http://sourceforge.net/projects/expect/ URL: http://expect.nist.gov/ -Source: http://downloads.sourceforge.net/%{name}/%{name}%{version}.tar.gz +Source: expect_5.44.1.14.orig.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Buildrequires: tcl-devel tk-devel autoconf automake libXft-devel chrpath # Patch0: fixes change log file permissions @@ -71,24 +72,25 @@ Please use tclsh with package require Tk and Expect instead of expectk. %prep -%setup -q -n expect%{version} -%patch0 -p1 -b .log_file -%patch1 -p1 -b .pkgpath -%patch2 -p1 -b .man-page -%patch3 -p1 -b .match-gt-numchars-segfault +%setup -q +#-n expect%{version} +#patch0 -p1 -b .log_file +#patch1 -p1 -b .pkgpath +#patch2 -p1 -b .man-page +#patch3 -p1 -b .match-gt-numchars-segfault # examples fixes -%patch100 -p1 -b .random -%patch101 -p1 -b .mkpasswd-dash -%patch102 -p1 -b .check-telnet -%patch103 -p1 -b .passmass-su-full-path +#patch100 -p1 -b .random +#patch101 -p1 -b .mkpasswd-dash +#patch102 -p1 -b .check-telnet +#patch103 -p1 -b .passmass-su-full-path # -pkgpath.patch touch configure.in -aclocal -autoconf -( cd testsuite - autoconf -I.. ) +#aclocal +#autoconf +#( cd testsuite +# autoconf -I.. ) %build -%configure --with-tcl=%{_libdir} --with-tk=%{_libdir} --enable-shared \ +%configure --with-tcl=%{tcl_sitearch} --with-tk=%{_libdir} --enable-shared \ --with-tclinclude=%{_includedir}/tcl-private/generic make %{?_smp_mflags} @@ -100,7 +102,10 @@ rm -rf "$RPM_BUILD_ROOT" make install DESTDIR="$RPM_BUILD_ROOT" # move -mv "$RPM_BUILD_ROOT"%{tcl_sitearch}/expect%{version}/libexpect%{version}.so "$RPM_BUILD_ROOT"%{_libdir} +mv "$RPM_BUILD_ROOT"%{_libdir}/expect%{version}/libexpect%{version}.so "$RPM_BUILD_ROOT"%{_libdir} +mkdir "$RPM_BUILD_ROOT"%{tcl_sitearch} +mkdir "$RPM_BUILD_ROOT"%{tcl_sitearch}/expect%{version} +mv "$RPM_BUILD_ROOT"%{_libdir}/expect%{version}/pkgIndex.tcl "$RPM_BUILD_ROOT"%{tcl_sitearch}/expect%{version}/ # for linking with -lexpect ln -s libexpect%{majorver}.so "$RPM_BUILD_ROOT"%{_libdir}/libexpect.so --VS++wcV0S1rZb1Fb--