From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94090-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4909 invoked by alias); 24 Aug 2012 13:40:04 -0000
Received: (qmail 4750 invoked by uid 22791); 24 Aug 2012 13:40:01 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 13:39:47 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7ODdl8Z006817	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 24 Aug 2012 09:39:47 -0400
Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7ODdhrc014488	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 24 Aug 2012 09:39:46 -0400
Date: Fri, 24 Aug 2012 13:40:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: consolidate checks for _Unwind_DebugHook in test suite
Message-ID: <20120824133931.GC5219@host2.jankratochvil.net>
References: <877gt1zbr5.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <877gt1zbr5.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00719.txt.bz2

On Tue, 14 Aug 2012 18:20:14 +0200, Tom Tromey wrote:
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
[...]
> +proc skip_unwinder_tests {} {
> +    global gdb_prompt
> +
> +    set ok 1
> +    gdb_test_multiple "print _Unwind_DebugHook" "check for unwinder hook" {
> +	-re "= .*no debug info.*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
> +	    # Pass the test so we don't get bogus fails in the results.
> +	    pass "check for unwinder hook"
> +	    set ok 0
> +	}
> +	-re "= .*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
> +	    pass "check for unwinder hook"
> +	}
> +	-re "No symbol .* in current context.\r\n$gdb_prompt $" {
> +	    # Pass the test so we don't get bogus fails in the results.
> +	    pass "check for unwinder hook"
> +	    set ok 0
> +	}
> +    }

If gdb_test_multiple FAILs it will leave "ok" as 1 which will run the whole
testfile.  Was it intentional?  Maybe it was although I would expect the
opposite.


Jan