From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28377 invoked by alias); 24 Aug 2012 13:34:12 -0000 Received: (qmail 28207 invoked by uid 22791); 24 Aug 2012 13:34:11 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 13:33:54 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7ODXqPq025985 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 24 Aug 2012 09:33:53 -0400 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7ODXn6O026051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 24 Aug 2012 09:33:51 -0400 Date: Fri, 24 Aug 2012 13:34:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Append "." in error message. Message-ID: <20120824133336.GA5219@host2.jankratochvil.net> References: <877gt1zbr5.fsf@fleche.redhat.com> <1345715389-20955-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1345715389-20955-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00717.txt.bz2 On Thu, 23 Aug 2012 11:49:48 +0200, Yao Qi wrote: > This patch is to add "." at the end of message "No symbol XXX in > current context", and fix a FAIL in testsuite. > > -FAIL: gdb.java/jnpe.exp: check for unwinder hook > +PASS: gdb.java/jnpe.exp: check for unwinder hook > +PASS: gdb.java/jnpe.exp: check for stap probe in unwinder > > It is obvious. I'll check it in. [...] > - error (_("No symbol \"%s\" in current context"), tmp); > + error (_("No symbol \"%s\" in current context."), tmp); Yes, please, to get out of all the pending regressions. I hope no other regressions are caused by it. Thanks, Jan