From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93932-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3402 invoked by alias); 21 Aug 2012 06:51:01 -0000
Received: (qmail 3388 invoked by uid 22791); 21 Aug 2012 06:51:00 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MAY_BE_FORGED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Aug 2012 06:50:45 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7L6oiPg015304	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 21 Aug 2012 02:50:44 -0400
Received: from spoyarek (dhcp223-8.pnq.redhat.com [10.65.223.8] (may be forged))	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7L6oggo023922;	Tue, 21 Aug 2012 02:50:43 -0400
Date: Tue, 21 Aug 2012 06:51:00 -0000
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: bitpos expansion patches summary
Message-ID: <20120821122009.647e520d@spoyarek>
In-Reply-To: <20120819164147.GA27469@host2.jankratochvil.net>
References: <20120805005350.150e5b74@spoyarek>	<20120819164147.GA27469@host2.jankratochvil.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00561.txt.bz2

On Sun, 19 Aug 2012 18:41:47 +0200, Jan wrote:
> SEPARATE(Ensure that the
> value fits into CORE_ADDR): (eval.c:2075):
> FUNC(value_from_pointer):	(LONGEST to CORE_ADDR)
> [value_as_long(arg1) + mem_offset]
>  - I do not understand this, you have correctly made 'long->LONGEST
> mem_offset;', I find it enough.

You're right, I can't remember what I was thinking.

> ENSURED_SIZET: (h8300-tdep.c:677):	FUNC(memset):
> (LONGEST to size_t)	[padded_len]
>  - This is redundant, there is already above it:
>    char *contents = (char *) value_contents (args[argument]);

Already removed in the latest patch.

I'll work on the rest.

Thanks,
Siddhesh