From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15608 invoked by alias); 17 Aug 2012 09:35:31 -0000 Received: (qmail 15463 invoked by uid 22791); 17 Aug 2012 09:35:28 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MAY_BE_FORGED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Aug 2012 09:34:51 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7H9Yopg026089 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Aug 2012 05:34:51 -0400 Received: from spoyarek (dhcp223-8.pnq.redhat.com [10.65.223.8] (may be forged)) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7H9YmAn011888; Fri, 17 Aug 2012 05:34:49 -0400 Date: Fri, 17 Aug 2012 09:35:00 -0000 From: Siddhesh Poyarekar To: gdb-patches@sourceware.org Cc: Jan Kratochvil Subject: Re: bitpos expansion patches summary Message-ID: <20120817145756.2415e8cb@spoyarek> In-Reply-To: <20120810065712.161f26ec@spoyarek> References: <20120805005350.150e5b74@spoyarek> <20120808224312.GA25869@host2.jankratochvil.net> <20120810065712.161f26ec@spoyarek> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/bbPaUi62ujn8BS0/Nhmb84I" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00475.txt.bz2 --MP_/bbPaUi62ujn8BS0/Nhmb84I Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 648 Hi, Here is an updated patch for the missed expansions. This should apply on top of the bitpos expansion patch. I have verified that the patch does not cause any regressions in the testsuite on x86_64. I have also run splint and the perl scripts to see if I have missed any more. Regards, Siddhesh gdb/ChangeLog: * ada-lang.c (ada_value_primitive_packed_val): Expand NEW_OFFSET to LONGEST. * arm-tdep.c (arm_vfp_cprc_sub_candidate): Expand COUNT to LONGEST. * dwarf2loc.c (indirect_pieced_value): Expand THIS_SIZE_BITS to LONGEST. * sh-tdep.c (sh_push_dummy_call_fpu): Expand REG_SIZE to ssize_t. (sh_push_dummy_call_nofpu): Likewise. --MP_/bbPaUi62ujn8BS0/Nhmb84I Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=bitpos-expand-missed-expand.patch Content-length: 1757 diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index c350a0e..9c305702 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -2312,7 +2312,7 @@ ada_value_primitive_packed_val (struct value *obj, const gdb_byte *valaddr, if (obj != NULL) { - long new_offset = offset; + LONGEST new_offset = offset; set_value_component_location (v, obj); set_value_bitpos (v, bit_offset + value_bitpos (obj)); diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index dc587e1..496cc30 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -3427,7 +3427,7 @@ arm_vfp_cprc_sub_candidate (struct type *t, case TYPE_CODE_STRUCT: { - int count = 0; + LONGEST count = 0; unsigned unitlen; int i; for (i = 0; i < TYPE_NFIELDS (t); i++) diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c index ad12e37..bef4355 100644 --- a/gdb/dwarf2loc.c +++ b/gdb/dwarf2loc.c @@ -1995,7 +1995,7 @@ indirect_pieced_value (struct value *value) for (i = 0; i < c->n_pieces && bit_length > 0; i++) { struct dwarf_expr_piece *p = &c->pieces[i]; - size_t this_size_bits = p->size; + ULONGEST this_size_bits = p->size; if (bit_offset > 0) { diff --git a/gdb/sh-tdep.c b/gdb/sh-tdep.c index 00d7401..1f599f8 100644 --- a/gdb/sh-tdep.c +++ b/gdb/sh-tdep.c @@ -1068,7 +1068,7 @@ sh_push_dummy_call_fpu (struct gdbarch *gdbarch, CORE_ADDR regval; char *val; LONGEST len; - int reg_size = 0; + ssize_t reg_size = 0; int pass_on_stack = 0; int treat_as_flt; int last_reg_arg = INT_MAX; @@ -1210,7 +1210,7 @@ sh_push_dummy_call_nofpu (struct gdbarch *gdbarch, CORE_ADDR regval; char *val; LONGEST len; - int reg_size = 0; + ssize_t reg_size = 0; int pass_on_stack = 0; int last_reg_arg = INT_MAX; --MP_/bbPaUi62ujn8BS0/Nhmb84I--