From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11547 invoked by alias); 13 Aug 2012 14:04:28 -0000 Received: (qmail 11538 invoked by uid 22791); 13 Aug 2012 14:04:27 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MAY_BE_FORGED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Aug 2012 14:04:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DE49Q2016844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 10:04:09 -0400 Received: from spoyarek (dhcp223-8.pnq.redhat.com [10.65.223.8] (may be forged)) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7DE47xQ023100; Mon, 13 Aug 2012 10:04:08 -0400 Date: Mon, 13 Aug 2012 14:04:00 -0000 From: Siddhesh Poyarekar To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: bitpos expansion patches summary Message-ID: <20120813193313.666715e1@spoyarek> In-Reply-To: <20120813134915.GA5960@host2.jankratochvil.net> References: <20120805005350.150e5b74@spoyarek> <20120812175730.GA5968@host2.jankratochvil.net> <20120813082124.2b80ffdf@spoyarek> <20120813134915.GA5960@host2.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00360.txt.bz2 On Mon, 13 Aug 2012 15:49:15 +0200, Jan wrote: > I was requesting only to remove the redundant line > avr-tdep.c:1298:ensure_type_fits_sizet (type); > OK, will do. > ensure_type_fits_sizet uses only TYPE->LENGTH so it does not need to > be passed TYPE at all. It would make sense if ensure_type_fits_sizet > prints TYPE_NAME in the error case etc. - but it does not use > TYPE_NAME anyway.. Sure, I can do that. > > Likewise for other tdep instances. > > I do not see how it can be generalized, I may not just see what do > you mean. I meant the other instances that you pointed out as unnecessary - sorry for the confusion. > > > (breakpoint.c:4624): FUNC(): (LONGEST to int) > > > [loc->length] > > > - That's not true, s390x can set arbitrary hardware watchpoint > > > memory range, see s390_fix_watch_points. WPFIXED(Expand > > > > Oh, then my assumption about watchpoint sizes would be wrong then > > wouldn't it? We then need to expand the ok_for_watchpoint as well as > > {insert|remove}_watchpoint. We could do it as a different changeset > > since only s390x would need it. > > You are right. Sorry I did not remember this s390x feature when we > discussed it before. No worries, I'll work on the watchpoint change once we get the rest of the stuff in if it is OK. Not having it in this change itself is not going to break something that is not already broken. Regards, Siddhesh