From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18742 invoked by alias); 13 Aug 2012 14:12:58 -0000 Received: (qmail 18699 invoked by uid 22791); 13 Aug 2012 14:12:56 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Aug 2012 14:12:40 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DECdf1007259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 10:12:40 -0400 Received: from host2.jankratochvil.net (ovpn-116-27.ams2.redhat.com [10.36.116.27]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7DECaPf001487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 13 Aug 2012 10:12:38 -0400 Date: Mon, 13 Aug 2012 14:12:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: bitpos expansion patches summary Message-ID: <20120813141236.GA7325@host2.jankratochvil.net> References: <20120805005350.150e5b74@spoyarek> <20120812175730.GA5968@host2.jankratochvil.net> <20120813082124.2b80ffdf@spoyarek> <20120813134915.GA5960@host2.jankratochvil.net> <20120813193313.666715e1@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120813193313.666715e1@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00361.txt.bz2 On Mon, 13 Aug 2012 16:03:13 +0200, Siddhesh Poyarekar wrote: > No worries, I'll work on the watchpoint change once we get the rest of > the stuff in if it is OK. Not having it in this change itself is not > going to break something that is not already broken. I am reluctant to check in the LENGTH expansion before getting all the needed pre-requisite bits fixed. One cannot properly regression-splint-check it afterwards anymore as HEAD is a moving target so it may start to be seriously difficult to be tracking the changes happening between LENGTH expansion and before all the other bits get it. The splint results will have changing line numbers etc. Maybe it is possible to handle it somehow but I would find easier to check the LENGTH expansion only as the last piece. Thanks, Jan