From: Oleg Nesterov <oleg@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Roland McGrath <roland@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ananth N Mavinakaynahalli <ananth@in.ibm.com>,
stan_shebs@mentor.com, gdb-patches@sourceware.org
Subject: Re: [RFC 5/5] uprobes: add global breakpoints
Date: Mon, 13 Aug 2012 13:20:00 -0000 [thread overview]
Message-ID: <20120813131623.GA5269@redhat.com> (raw)
In-Reply-To: <20120809171802.GB27835@linutronix.de>
On 08/09, Sebastian Andrzej Siewior wrote:
>
> * Oleg Nesterov | 2012-08-08 15:14:57 [+0200]:
>
> >> What I miss right now is an interface to tell the user/gdb that there is a
> >> program that hit a global breakpoint and is waiting for further instructions.
> >> A "tail -f trace" does not work and may contain also a lot of other
> >> informations. I've been thinking about a poll()able file which returns pids of
> >> tasks which are put on hold. Other suggestions?
> >
> >Honestly, I am not sure this is that useful...
>
> How would you notify gdb that there is a new task that hit a breakpoint?
> Or learn yourself?
But why do we need this?
OK, you do not need to convince me, I try to never argue with
new features.
However, I certainly dislike TASK_TRACED in uprobe_wait_traced().
And sleeping in ->handler() is not fair to other consumers.
And I do not think you should modify ptrace_attach() at all.
gdb/user can wakeup the task after PTRACE_ATTACH itself.
Oleg.
next prev parent reply other threads:[~2012-08-13 13:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1344355952-2382-1-git-send-email-bigeasy@linutronix.de>
2012-08-07 16:13 ` Sebastian Andrzej Siewior
2012-08-08 13:19 ` Oleg Nesterov
2012-08-09 17:18 ` Sebastian Andrzej Siewior
2012-08-13 13:20 ` Oleg Nesterov [this message]
2012-08-14 11:44 ` Sebastian Andrzej Siewior
2012-08-09 18:25 ` Stan Shebs
2012-08-13 11:35 ` Peter Zijlstra
2012-08-20 15:27 ` Sebastian Andrzej Siewior
2012-08-21 19:42 ` [RFC 5/5 v2] " Sebastian Andrzej Siewior
2012-08-22 13:53 ` Oleg Nesterov
2012-08-27 18:57 ` Sebastian Andrzej Siewior
2012-08-29 15:48 ` Oleg Nesterov
2012-08-30 20:42 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813131623.GA5269@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ananth@in.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=gdb-patches@sourceware.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=stan_shebs@mentor.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox