From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10013 invoked by alias); 9 Aug 2012 02:04:51 -0000 Received: (qmail 10005 invoked by uid 22791); 9 Aug 2012 02:04:49 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Aug 2012 02:04:32 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7924V10011594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 Aug 2012 22:04:31 -0400 Received: from spoyarek (vpn-238-101.phx2.redhat.com [10.3.238.101]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7924TO5031338; Wed, 8 Aug 2012 22:04:30 -0400 Date: Thu, 09 Aug 2012 02:04:00 -0000 From: Siddhesh Poyarekar To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: bitpos expansion patches summary Message-ID: <20120809073403.7c706d3f@spoyarek> In-Reply-To: <20120808224312.GA25869@host2.jankratochvil.net> References: <20120805005350.150e5b74@spoyarek> <20120808224312.GA25869@host2.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00274.txt.bz2 On Thu, 9 Aug 2012 00:43:12 +0200, Jan wrote: > Hi Siddhesh, > > I have found one problem. We miss the cases (there won't be too > many) like: > > ada-lang.c:2315 > offset is LONGEST: > long new_offset = offset; I think that is my fault - splint gave that warning, but I missed it when copying over my annotations from the old report to the new one: RSAFE: (ada-lang.c:2315): VARINIT(new_offset): (LONGEST to LONG) [offset] Split gave these warnings when I ran it for the new report, which is why I also had to modify the processing script to account for a LONG and ULONG as opposed to LONGEST and ULONGEST. I'll review the changes and send a fix for this on top of the current patches. Regards, Siddhesh