From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93642-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31008 invoked by alias); 8 Aug 2012 22:43:37 -0000
Received: (qmail 30998 invoked by uid 22791); 8 Aug 2012 22:43:36 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 22:43:18 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q78MhHYi015120	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 8 Aug 2012 18:43:17 -0400
Received: from host2.jankratochvil.net (ovpn-116-46.ams2.redhat.com [10.36.116.46])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q78MhDqB020604	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 8 Aug 2012 18:43:16 -0400
Date: Wed, 08 Aug 2012 22:43:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: bitpos expansion patches summary
Message-ID: <20120808224312.GA25869@host2.jankratochvil.net>
References: <20120805005350.150e5b74@spoyarek>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120805005350.150e5b74@spoyarek>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00271.txt.bz2

Hi Siddhesh,

I have found one problem.  We miss the cases (there won't be too many) like:

ada-lang.c:2315
offset is LONGEST:
      long new_offset = offset;

As on x86_64 LONGEST is #defined as 'long'.  But on LLP64 (MS-Windows IA64)
	http://en.wikipedia.org/wiki/64-bit#64-bit_data_models
'long' is 32-bit but LONGEST is (presumably) still 64-bit.

'long' should be changed to 'LONGEST' at ada-lang.c:2315.

It probably requires to run splint also in 32-bit mode (on GNU/Linux).


Thanks,
Jan