From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93623-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18149 invoked by alias); 8 Aug 2012 11:57:37 -0000
Received: (qmail 18141 invoked by uid 22791); 8 Aug 2012 11:57:36 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,TW_XF,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 11:57:23 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q78BvIvr000510;	Wed, 8 Aug 2012 13:57:18 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q78BvGVv006049;	Wed, 8 Aug 2012 13:57:16 +0200 (CEST)
Date: Wed, 08 Aug 2012 11:57:00 -0000
Message-Id: <201208081157.q78BvGVv006049@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: palves@redhat.com
CC: sergiodj@redhat.com, gdb-patches@sourceware.org, tromey@redhat.com,        jan.kratochvil@redhat.com
In-reply-to: <5018ECBE.4020007@redhat.com> (message from Pedro Alves on Wed,	01 Aug 2012 09:45:50 +0100)
Subject: Re: [PATCH] Adjust `pc-fp.exp' for ppc64/s390x (PR 12659)
References: <m3mx2fmxmb.fsf@redhat.com> <5018ECBE.4020007@redhat.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00252.txt.bz2

> Date: Wed, 01 Aug 2012 09:45:50 +0100
> From: Pedro Alves <palves@redhat.com>
> 
> On 07/31/2012 10:25 PM, Sergio Durigan Junior wrote:
> > While regtesting 7.4 against 7.5 branch on ppc64/s390x RHEL 6.3, I
> > noticed this failure.  The patch which introduced this failure was
> > committed because of:
> > 
> >       http://sourceware.org/bugzilla/show_bug.cgi?id=12659
> > 
> > On x86*, the output of `info register pc fp' is:
> > 
> >     info register pc fp
> >     pc: 0x400520
> >     fp: 0x7fffffffc490
> >     (gdb) PASS: gdb.base/pc-fp.exp: info register pc fp
> > 
> > On ppc64/s390x, it is:
> > 
> >     info register pc fp
> >     pc             0x10000658       0x10000658 <main+20>
> >     fp: 0xfffffffd120
> >     (gdb) FAIL: gdb.base/pc-fp.exp: info register pc fp
> > 
> > Since this difference in the output does not seem to be an error itself,
> > the patch below just adjusts the testcase to match this kind of output
> > as well.  It does not fail on x86*.
> 
> Why is the output format different?  It looks like consistency here
> would be good.

Indeed.  So I'd say patching up the testsuite for this difference
would be the wrong way to go.