Re: bitpos expansion patches summary

Siddhesh Poyarekar
2012-08-21T06:51:01Z

On Sun, 19 Aug 2012 18:41:47 +0200, Jan wrote:
> SEPARATE(Ensure that the
> value fits into CORE_ADDR): (eval.c:2075):
> FUNC(value_from_pointer): (LONGEST to CORE_ADDR)
> [value_as_long(arg1) + mem_offset]
> - I do not understand this, you have correctly made 'long->LONGEST
> mem_offset;', I find it enough.

You're right, I can't remember what I was thinking.

> ENSURED_SIZET: (h8300-tdep.c:677): FUNC(memset):
> (LONGEST to size_t) [padded_len]
> - This is redundant, there is already above it:
> char *contents = (char *) value_contents (args[argument]);

Already removed in the latest patch.

I'll work on the rest.

Thanks,
Siddhesh