From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22074 invoked by alias); 4 Aug 2012 19:24:29 -0000 Received: (qmail 22063 invoked by uid 22791); 4 Aug 2012 19:24:28 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Aug 2012 19:24:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q74JODt3030340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 4 Aug 2012 15:24:14 -0400 Received: from spoyarek (vpn-237-183.phx2.redhat.com [10.3.237.183]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q74JOBv3002756 for ; Sat, 4 Aug 2012 15:24:12 -0400 Date: Sat, 04 Aug 2012 19:24:00 -0000 From: Siddhesh Poyarekar To: gdb-patches@sourceware.org Subject: bitpos expansion patches summary Message-ID: <20120805005350.150e5b74@spoyarek> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00144.txt.bz2 Hi, I have finally finished another instance of the bitpos changes after reviewing the report from the processed splint output. Please see the following discussion for context on this: http://sourceware.org/ml/gdb-patches/2012-06/msg00851.html I have uploaded a new version of the splint outputs and reports here: http://siddhesh.fedorapeople.org/20120805-splint-bitpos.tar.xz I have broken down the patch into three parts: * The first part is the original patch with additional type expansions done as needed. The other major change is that I have reverted expansion of insert/remove watchpoint functions, since the ok_for_watchpoint function should take care of the sizes that go into them. * The second part implements checks to ensure that types fit into size_t whenever they need to be written out/read using native functions like memcpy, memcmp, write_memory, etc. * The final part is a small change in python-types.c. I've kept this separate just for the sake of clarity. These patches and their changelogs will follow shortly. For all the patches, I have run the testsuite to ensure that I don't introduce any regressions on x86_64. I have also reviewed the splint output to try and ensure that I haven't missed any places that need to be expanded. There are however a couple of cases where I was not sure what to do and they are marked as such in the report. Regards, Siddhesh