From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19235 invoked by alias); 3 Aug 2012 15:08:53 -0000 Received: (qmail 19224 invoked by uid 22791); 3 Aug 2012 15:08:52 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_VG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Aug 2012 15:08:36 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q73F7nv2007319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 Aug 2012 11:07:49 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q73F7ivo009893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 3 Aug 2012 11:07:46 -0400 Date: Fri, 03 Aug 2012 15:08:00 -0000 From: Jan Kratochvil To: Edjunior Barbosa Machado Cc: Tom Tromey , Pedro Alves , Sergio Durigan Junior , Philippe Waroquiers , Joel Brobecker , gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: [commit+7.5] [patchv2] Write bpt at the ON_STACK bpt address Message-ID: <20120803150740.GA2159@host2.jankratochvil.net> References: <5012B1B6.1030003@redhat.com> <1343339398.2258.119.camel@soleil> <20120727184633.GA14182@host2.jankratochvil.net> <20120731073643.GA18696@host2.jankratochvil.net> <501B03E4.1020209@linux.vnet.ibm.com> <501B2271.6030406@redhat.com> <87lihwoy14.fsf@fleche.redhat.com> <20120803143011.GA32485@host2.jankratochvil.net> <501BE7E4.1030703@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <501BE7E4.1030703@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00115.txt.bz2 On Fri, 03 Aug 2012 17:01:56 +0200, Edjunior Barbosa Machado wrote: > the patch below aborts the testcase if vgdb remote connection is closed, > avoiding the testsuite to get stuck in the `continue' loop that happens when > occurs the internal-error. It also considers the leading `.' for _start(), > which is expected in ppc64. OK with the change below, so that the same testcase name appears during diffs of various testsuite results. > --- a/gdb/testsuite/gdb.base/valgrind-infcall.exp > +++ b/gdb/testsuite/gdb.base/valgrind-infcall.exp [...] > @@ -97,6 +97,10 @@ while 1 { > pass $test > break > } > + -re "Remote connection closed.*\r\n$gdb_prompt $" { > + fail "Remote connection closed. Testcase aborted" fail "$test (remote connection closed)" > + return -1 > + } > -re "\r\n$gdb_prompt $" { > pass "$test (false warning)" > } Thanks, Jan