Re: [patch] MI telnet service

Jan Kratochvil
2012-07-15T08:13:48Z

On Thu, 12 Jul 2012 16:36:43 +0200, Abid, Hafiz wrote:
> I thought we are not required to follow the convention in the test program
> source. Anyway, I will fix it with the rest. Thanks for reviewing.

Like it is not worth to for example fix indentation in the existing testcases.
But checking in a new testcase with very different formatting style does not
make it easily fixable/update-able later. At least run indent with the
options from GNU Coding Standard:
-nbad -bap -nbc -bbo -bl -bli2 -bls -ncdb -nce -cp1 -cs -di2 -ndj -nfc1 -nfca -hnl -i2 -ip5 -lp -pcs -psl -nsc -nsob

Thanks,
Jan