Re: [patch] [i386] Put hlt at the ON_STACK breakpoint [Re: GDB 7.4.91 available for testing]

Jan Kratochvil
2012-07-26T05:13:35Z

On Wed, 25 Jul 2012 23:46:15 +0200, Philippe Waroquiers wrote:
> A valid instruction is not enough. We need a valid instruction
> that will cause Valgrind to terminate block translation.
> The breakpoint trap instruction is ok for that.
> (0xcc for x86 and amd64, 0x0005000d for mips32).

I understand now that int3 is enough for valgrind.
I still do not understand whether hlt is enough for valgrind.
I will try how hlt behaves with a testcase.

Still as you both (with Joel) seem to prefer int3 over hlt I will put int3
there. IIUC your goals this will make false feeling to the user s/he
understands what is going which seems to be better than if the user sees hlt
which may be more unclear to him/her.

Thanks,
Jan