Re: [patchv2] Write bpt at the ON_STACK bpt address

Eli Zaretskii
2012-07-28T07:28:21Z

> Date: Fri, 27 Jul 2012 20:46:33 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org, "Maciej W. Rozycki" <macro@codesourcery.com>
>
> -breakpoint should be inserted. May return @code{NULL} to indicate that
> -software breakpoints are not supported.
> +breakpoint should be inserted. The program counter (@code{*@var{pcptr}}
> +is inferior PC register encoded on the input and it is a plain address on the
> +output. Function may return @code{NULL} to indicate that software breakpoints
> +are not supported.

I suggest a slight rewording:

On input, the program counter (@code{*@var{pcptr}} is the encoded
inferior's PC register. The function returns the PC's plain address
in this argument, or @code{NULL} if software breakpoints are not
supported.

Does this catch the intent correctly?

> -the return address (@var{bp_addr}).
> +the return address (@var{bp_addr}, in inferior PC register encoding).
^^^^^^^^
"inferior's"

> -should be inserted, @var{real_pc} to the resume address when starting
> -the call sequence, and return the updated inner-most stack address.
> +should be inserted (in inferior PC register encoding), @var{real_pc} to the
^^^^^^^^
Likewise.

> -reserved for that breakpoint, and @var{real_pc} set to @var{funaddr}.
> +reserved for that breakpoint (in inferior PC register encoding), and
^^^^^^^^
Likewise.

OK with these changes.

Thanks.