From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27234 invoked by alias); 28 Jul 2012 06:06:33 -0000 Received: (qmail 27224 invoked by uid 22791); 28 Jul 2012 06:06:32 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Jul 2012 06:06:10 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6S65poJ001985 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 28 Jul 2012 02:05:51 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6S65jQG028829 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 28 Jul 2012 02:05:48 -0400 Date: Sat, 28 Jul 2012 06:06:00 -0000 From: Jan Kratochvil To: "Maciej W. Rozycki" Cc: Joel Brobecker , Philippe Waroquiers , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patchv2] Write bpt at the ON_STACK bpt address Message-ID: <20120728060538.GA1698@host2.jankratochvil.net> References: <1343075809.2209.53.camel@soleil> <501009AE.40901@redhat.com> <1343247870.2240.29.camel@soleil> <20120725212653.GC2767@adacore.com> <1343252775.2240.51.camel@soleil> <20120725223933.GD2767@adacore.com> <20120726212339.GA1710@host2.jankratochvil.net> <20120727160200.GA6628@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00713.txt.bz2 On Sat, 28 Jul 2012 02:10:23 +0200, Maciej W. Rozycki wrote: > I have tested your change now, applied on top of current trunk and that > caused no regressions throughout all the configurations involved, so it > looks good to go in as far as I'm concerned. OK, I will check it in. > Sadly there are some regressions in the baseline I used, compared to the > last previous test results I obtained a couple weeks ago. Specifically > these: > > FAIL: gdb.base/dprintf.exp: 1st dprintf, gdb > FAIL: gdb.base/dprintf.exp: 2nd dprintf, gdb [ and other FAILs ] It was a very recent regression lasting only one day, fixed by Keith: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers http://sourceware.org/ml/gdb-patches/2012-07/msg00593.html commit 5134bbd001531c5c6d02573d4d7fb86b17a549ec Author: Keith Seitz Date: Thu Jul 26 16:22:44 2012 +0000 * linespec.c (linespec_lexer_lex_number): The input is also a valid number if the next character is a comma or colon. Thanks, Jan