From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28628 invoked by alias); 26 Jul 2012 13:55:16 -0000 Received: (qmail 28619 invoked by uid 22791); 26 Jul 2012 13:55:14 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jul 2012 13:54:58 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6QDsvUP014601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Jul 2012 09:54:57 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6QDsrGV013937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 26 Jul 2012 09:54:55 -0400 Date: Thu, 26 Jul 2012 13:55:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Doug Evans Subject: [patch] Remove one immediate_quit++-- (in auto-load.c) Message-ID: <20120726135446.GA15749@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00614.txt.bz2 Hi Doug, Tom has notified me on #gdb there was one needless and probably even incorrect immediate_quit++ (and --). despite it is in auto-load.c it was only moved there with other code, it originates from patch: commit 47d11be572aaf42cc67e6d925271d44bdecd104d Author: Doug Evans Date: Fri Apr 23 16:20:08 2010 +0000 Add support for auto-loading scripts from .debug_gdb_scripts section. Originally there was printf_filtered which does not need it. Later it is just around code with no UI output: commit 2e0e11bc91732db59fe04fca4f2dceff2bb4a2ad Author: Doug Evans Date: Fri May 13 22:11:45 2011 +0000 I will check it in. Thanks, Jan gdb/ 2012-07-26 Jan Kratochvil * auto-load.c (auto_load_info_scripts): Remove immediate_quit increment and decrement. diff --git a/gdb/auto-load.c b/gdb/auto-load.c index 87dd1e4..2cc52c6 100644 --- a/gdb/auto-load.c +++ b/gdb/auto-load.c @@ -916,11 +916,9 @@ auto_load_info_scripts (char *pattern, int from_tty, { struct collect_matching_scripts_data data = { &scripts, language }; - immediate_quit++; /* Pass a pointer to scripts as VEC_safe_push can realloc space. */ htab_traverse_noresize (pspace_info->loaded_scripts, collect_matching_scripts, &data); - immediate_quit--; } nr_scripts = VEC_length (loaded_script_ptr, scripts);